Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing timestamp type to int64 #834

Closed
4 tasks
staheri14 opened this issue Jan 26, 2022 · 0 comments · Fixed by #842
Closed
4 tasks

Changing timestamp type to int64 #834

staheri14 opened this issue Jan 26, 2022 · 0 comments · Fixed by #842
Assignees
Labels
good first issue Good for newcomers

Comments

@staheri14
Copy link
Contributor

staheri14 commented Jan 26, 2022

Following the discussion in vacp2p/rfc#448, the decision has been made to use int64 type to represent timestamp values across wakuv2 protocols where the time values going to indicate the Unix epoch time in milliseconds. This includes

This change will touch the following parts of the codebase (non-exclusive):

Acceptance Criteria

  • The codebase should be refactored to accommodate this change (making sure all the tests pass successfully)
  • The corresponding specs i.e., Waku2-Store and Waku2-Message should reflect this change
  • Changelog should have an entry briefly explaning this update
  • A migration script should be added to migration scripts directory to handle the schema update in the Message table
@staheri14 staheri14 added the good first issue Good for newcomers label Jan 26, 2022
@s1fr0 s1fr0 self-assigned this Feb 1, 2022
@s1fr0 s1fr0 linked a pull request Feb 3, 2022 that will close this issue
3 tasks
@staheri14 staheri14 mentioned this issue Feb 9, 2022
3 tasks
s1fr0 added a commit to vacp2p/rfc that referenced this issue Feb 17, 2022
* Timestamps refactored to int64 (nanoseconds resolution). Related to waku-org/nwaku#834

* Updated times to Timestamp type

* Refactored timestamps

* Made spec consistent with timestamp refactoring

* Fixed misunderstanding on proto3 types

* Fixed timestamps to sint64

* Fixed correct time to pb2 timestamps and Store protocol version changed to beta4

* Revert changes (not needed for now)

* Revert changes

We'll change to sint64 when we'll refactor chat2 to use Timestamp type for timestamps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants