the rpc method implementation is ok. but the actual implementation of rpcEstimateGas is incorrect

[advaita-saha]

          the rpc method implementation is ok. but the actual implementation of rpcEstimateGas itself probably need more test. will merge for now

Originally posted by @jangko in #2701 (comment)

[advaita-saha]

Needs revisitation to https://eips.ethereum.org/EIPS/eip-1559
For transaction normalisation

[advaita-saha]

From Kurtosis debug
DBG 2024-10-23 20:09:31.865+00:00 Error occurred within RPC methodName=eth_estimateGas err="rpcEstimateGas error: EvmInvalidParam"

[advaita-saha]

WRN 2024-10-23 20:08:53.995+00:00 Gas estimation capped by limited funds original=9223372036854775807 balance=1000000000000000000000000000 sent=400000000000000000 maxFeePerGas=30000000000 fundable=33333333320000000

[jangko]

For transaction normalisation

either use maxPriorityFeePerGasNorm and maxFeePerGasNorm or eip1559TxNormalization(slow due to tx copy)

nimbus-eth1/nimbus/core/executor/process_transaction.nim

Line 78 in fc5ea1c

priorityFee = min(tx.maxPriorityFeePerGasNorm(), tx.maxFeePerGasNorm() - baseFee)

nimbus-eth1/nimbus/transaction.nim

Lines 154 to 177 in fc5ea1c

	func eip1559TxNormalization*(tx: Transaction;
	baseFeePerGas: GasInt): Transaction =
	## This function adjusts a legacy transaction to EIP-1559 standard. This
	## is needed particularly when using the `validateTransaction()` utility
	## with legacy transactions.
	result = tx
	if tx.txType < TxEip1559:
	result.maxPriorityFeePerGas = tx.gasPrice
	result.maxFeePerGas = tx.gasPrice
	else:
	result.gasPrice = baseFeePerGas +
	min(result.maxPriorityFeePerGas, result.maxFeePerGas - baseFeePerGas)
	func maxPriorityFeePerGasNorm*(tx: Transaction): GasInt =
	if tx.txType < TxEip1559:
	tx.gasPrice
	else:
	tx.maxPriorityFeePerGas
	func maxFeePerGasNorm*(tx: Transaction): GasInt =
	if tx.txType < TxEip1559:
	tx.gasPrice
	else:
	tx.maxFeePerGas