Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contentLookup/traceContentLookup + add failed requests to traceContentLookup #2908

Open
kdeme opened this issue Dec 4, 2024 · 0 comments

Comments

@kdeme
Copy link
Contributor

kdeme commented Dec 4, 2024

When currently doing a traceContentLookup, if the request failes (e.g. uTP connection set-up) this is not available in the returned responses of the trace. This makes it not immediately clear from the trace result that these nodes did get contacted by the node.

This should be added, here: https://github.com/status-im/nimbus-eth1/blob/master/fluffy/network/wire/portal_protocol.nim#L1427

However, in the current implementation we have no access to the information of the target node at the failure point.
One way would be to provide that in the error result, but that is not so clean. It would probably better to refactor the code to have some worker functions that deal with the FindContent requests and also add the results to the trace data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant