fix: log-level being ignored

[alrevuelta]

Closes #1197

Problem:

• Without -d:chronicles_runtime_filtering:on flag setLogLevel does not work.
• setLogLevel only works with levels less verbose than -d:chronicles_log_level=xxx, i.e. setLogLevel(TRACE) won't work if -d:chronicles_log_level=INFO.
• More info here.

Solution:

• Add -d:chronicles_runtime_filtering:on when compiling all binaries
• Set -d:chronicles_log_level=TRACE to all nwaku app and wakunode2

Now the following works as expected. Note that default is INFO.

$ ./build/wakunode2 --log-level=TRACE
$ ./build/wakunode2 --log-level=DEBUG
$ ./build/wakunode2 --log-level=WARN

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	cd8931e	#1	2022-10-17 15:38:41	~18 min	linux	📦bin
✔️	cd8931e	#1	2022-10-17 15:38:41	~18 min	macos	📦bin
✔️	e4fb43a	#2	2022-10-18 18:51:11	~16 min	linux	📦bin
✔️	e4fb43a	#2	2022-10-18 18:55:19	~20 min	macos	📦bin

[LNSD]

LGTM ✅

[jakubgs]

Thanks.

[jm-clius]

LGTM. One thing to consider is that the default log level almost everywhere will now be INFO, whereas previously it would have been DEBUG after compilation. We may want to change the default for fleet deployments to DEBUG so that we can continue using it as before: https://github.com/status-im/infra-role-nim-waku/blob/master/defaults/main.yml#L19

[jakubgs]

@jm-clius actually we already explicitly set log level to info:

 > a all -a 'grep log-level /docker/nim-waku/docker-compose.yml'
node-01.do-ams3.wakuv2.prod | CHANGED | rc=0 >>
      --log-level=info
node-01.gc-us-central1-a.wakuv2.prod | CHANGED | rc=0 >>
      --log-level=info
node-01.ac-cn-hongkong-c.wakuv2.prod | CHANGED | rc=0 >>
      --log-level=info

node-01.do-ams3.wakuv2.test | CHANGED | rc=0 >>
      --log-level=info
node-01.gc-us-central1-a.wakuv2.test | CHANGED | rc=0 >>
      --log-level=info
node-01.ac-cn-hongkong-c.wakuv2.test | CHANGED | rc=0 >>
      --log-level=info

node-01.do-ams3.status.test | CHANGED | rc=0 >>
      --log-level=info
node-01.gc-us-central1-a.status.test | CHANGED | rc=0 >>
      --log-level=info
node-01.ac-cn-hongkong-c.status.test | CHANGED | rc=0 >>
      --log-level=info

But we can always change that.

[jm-clius]

actually we already explicitly set log level to info:

Yeah, indeed (info explicitly set for fleet deployments and it's now the default for everyone running nodes without explicit configuration). Since we're using logging quite extensively for debugging on the fleets, we should change the log level to DEBUG. Other node operators may also expect debug level logs, so we'll have to inform them that default behaviour has changed.

[jakubgs]

Okay, done:

• status-im/infra-status@13aa35f1 - status: change log level to debug
• status-im/infra-nim-waku@015f41c1 - wakuv2.test/prod: change log level to debug