Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned message popup does not display edited messages #16639

Open
glitchminer opened this issue Oct 28, 2024 · 0 comments · May be fixed by #16894
Open

Pinned message popup does not display edited messages #16639

glitchminer opened this issue Oct 28, 2024 · 0 comments · May be fixed by #16894
Assignees
@jrainville
Labels
bug Something isn't working core-team goal:core:P0:messaging_active_users
Milestone
2.33.0 Beta

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

If a message is edited after it is pinned the edit is not displayed in the pinned message pop up.

Steps to reproduce

  1. Send a message
  2. Pin the message
  3. Edit the message
  4. Review pinned message pop up

Image

Expected behavior

Edits are displayed in the pinned message pop up

Additional Information

  • Status desktop version: 2.31 RC 1
  • Operating System: Mac
@glitchminer glitchminer added bug Something isn't working core-team labels Oct 28, 2024
@glitchminer glitchminer added this to the 2.32.0 Beta milestone Oct 28, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@jrainville jrainville self-assigned this Dec 5, 2024
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Dec 5, 2024
jrainville added a commit that referenced this issue Dec 5, 2024
@jrainville
fix(pins): fix edits not showing in the pinned messages until restart
9ee63c5 
Fixes #16639
jrainville added a commit to status-im/status-go that referenced this issue Dec 5, 2024
@jrainville
fix(pins)_: delete pins when the og message is deleted
db19ecc 
Found when fixing status-im/status-desktop#16639

When a message is deleted, we need to delete the pins too as they are no longer available.
I also made sure the SELECT query for the pins doesn't return deleted messages
@jrainville jrainville mentioned this issue Dec 5, 2024
Merged
jrainville added a commit that referenced this issue Dec 5, 2024
@jrainville
fix(pins): fix edits not showing in the pinned messages until restart
df1dbab 
Fixes #16639
@jrainville jrainville linked a pull request Dec 5, 2024 that will close this issue
Open
2 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 5, 2024
jrainville added a commit to status-im/status-go that referenced this issue Dec 5, 2024
@jrainville
fix(pins)_: delete pins when the og message is deleted
793bd0e 
Found when fixing status-im/status-desktop#16639

When a message is deleted, we need to delete the pins too as they are no longer available. This was done using an ON DELETE clause (thanks @osmaczko)
I also made sure the SELECT query for the pins doesn't return deleted messages
jrainville added a commit to status-im/status-go that referenced this issue Dec 12, 2024
@jrainville
fix(pins)_: delete pins when the og message is deleted (#6173)
5a8310d 
Found when fixing status-im/status-desktop#16639

When a message is deleted, we need to delete the pins too as they are no longer available. This was done using an ON DELETE clause (thanks @osmaczko)
I also made sure the SELECT query for the pins doesn't return deleted messages
jrainville added a commit that referenced this issue Dec 12, 2024
@jrainville
fix(pins): fix edits not showing in the pinned messages until restart
609ecbc 
Fixes #16639
jrainville added a commit that referenced this issue Dec 13, 2024
@jrainville
fix(pins): fix edits not showing in the pinned messages until restart
0402861 
Fixes #16639
jrainville added a commit that referenced this issue Dec 16, 2024
@jrainville
fix(pins): fix edits not showing in the pinned messages until restart
86a6d48 
Fixes #16639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working core-team goal:core:P0:messaging_active_users
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

Fixes to pinned messages status-im/status-desktop
2 participants
@jrainville @glitchminer