Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nbsp displayed in review contact request #16601

Open
glitchminer opened this issue Oct 24, 2024 · 1 comment · May be fixed by #17018
Open

nbsp displayed in review contact request #16601

glitchminer opened this issue Oct 24, 2024 · 1 comment · May be fixed by #17018
Assignees
@jrainville
Labels
bug Something isn't working core-team E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Milestone
2.33.0 Beta

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

A contact request text containing consecutive spaces is displayed with the nbsp character.

Image

Steps to reproduce

  1. Sent contact request containing multiple consecutive spaces
  2. Receiver reviews contact request by opening Details option from contact request notification
  3. Review contact request popup

Image

Additional Information

  • Status desktop version: 2.30.1 and 2.31 RC 1
  • Operating System: Mac
@glitchminer glitchminer added bug Something isn't working core-team labels Oct 24, 2024
@glitchminer glitchminer added this to the 2.32.0 Beta milestone Oct 24, 2024
@caybro caybro added the E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests label Oct 24, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@jrainville jrainville assigned jrainville and unassigned jrainville Dec 9, 2024
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Dec 31, 2024
@jrainville jrainville self-assigned this Dec 31, 2024
jrainville added a commit that referenced this issue Dec 31, 2024
@jrainville
fix(ac): fix review CR popup not showing correct data from the AC
525e3dd 
Fixes #16601

The original issue of seeing ` `  was already fixed, but the popup, when opening from the activity center didn't have any spaces.
However, when displayed from the profile, everything showed fine.
So the fix was simply to remove the old way of opening from the AC and use the same call that is used in the profile popup.
@jrainville
Copy link
Member

It seems like there is no longer &nbsp displayed, but the spaces are not appearing at all anymore.
I'll fix.

Image

@jrainville jrainville linked a pull request Dec 31, 2024 that will close this issue
Open
3 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working core-team E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(ac): fix review CR popup not showing correct data from the AC status-im/status-desktop
3 participants
@caybro @jrainville @glitchminer