Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: additional message filters are installed after app starts which may not be needed #5355

Closed
Tracked by #219
chaitanyaprem opened this issue Jun 14, 2024 · 0 comments · Fixed by #5366
Closed
Tracked by #219
Assignees

Comments

@chaitanyaprem
Copy link
Contributor

chaitanyaprem commented Jun 14, 2024

Problem

While doing dogfooding of #4665 PR, i had noticed additional filters getting installed for a user who has only 2 contacts and part of 1 private group(with 14 other people).
And as the app was left running overnight, the number of message filters kept on increasing which means it would increase number of filter subscriptions as well which may not be required.

Discord convo for more details https://discord.com/channels/1110799176264056863/1250038704882323457

Acceptance Criteria

All filters for a user are to be installed during startup unless user adds contacts later/joins community.
We should not be listening for messages from users that are not in our contacts.

Notes

@cammellos As discussed here is the stack traces for filters registered during startup of the app and after ~2hours of the app running. It may help identify the root-cause as to why additional filters are being installed.

stacktrace-fiilter-registration-after-1hour.log
filters_registration_startup_stacktrace.log

Also attaching complete geth.log
geth.log.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants