We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SensitiveString
Though I there's a drawback here. Adding a field that should be logged, will require user to keep in mind to add it to Marshal function.
Marshal
I googled this solution, it looks much cleaner and scalable:
type SensitiveString string {} func (SensitiveString s) String () string { return "****" } func (SensitiveString s) Value() string { return s }
I guess we can merge as is and open an issue to fix all places for to use such approach. cc @osmaczko
Originally posted by @igor-sirotin in #5677 (review)
The text was updated successfully, but these errors were encountered:
as discussed on status-go guild: (https://docs.google.com/spreadsheets/d/1CerD7oQZVt0kYeSve9IGOtnIgJZ0MPLyTKwoKC77Dtc/edit?gid=0#gid=0)
We can have a 'sensitive string' data type, which will also log nothing in any production build
Sorry, something went wrong.
igor-sirotin
Successfully merging a pull request may close this issue.
Though I there's a drawback here. Adding a field that should be logged, will require user to keep in mind to add it to
Marshal
function.I googled this solution, it looks much cleaner and scalable:
I guess we can merge as is and open an issue to fix all places for to use such approach.
cc @osmaczko
Originally posted by @igor-sirotin in #5677 (review)
The text was updated successfully, but these errors were encountered: