Replies: 5 comments
-
On that note, wondering if this also makes sense for other shared stuff like for e.g, translations, and assets - so long it doesn't introduce a noticeable overhead |
Beta Was this translation helpful? Give feedback.
-
I've looked into this and i should say, there will be not much profit from separating provider.js , because most logic is in status-react and status-go, provider.js just a tiny warper used for redirect request from the webview to the application, also we can't use it as npm library, it should be included in the project as a string, so i wouldn't separate it |
Beta Was this translation helpful? Give feedback.
-
I think it's still worth it, Also why do you say we can't include it as an npm library? |
Beta Was this translation helpful? Give feedback.
-
yeah probably we can slurp it from node modules folder |
Beta Was this translation helpful? Give feedback.
-
Moving to a discussion, good to re-evaluate as we start working on brwoser |
Beta Was this translation helpful? Give feedback.
-
In order to share code with desktop and better identify compatibility issues with other providers (metamask/ether.js) we should separate the js code in a separate repo and share it with desktop.
Beta Was this translation helpful? Give feedback.
All reactions