Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing typed data with wrong chain ID fails without proper error message #11706

Closed
bitgamma opened this issue Feb 2, 2021 · 4 comments · Fixed by #12170
Closed

signing typed data with wrong chain ID fails without proper error message #11706

bitgamma opened this issue Feb 2, 2021 · 4 comments · Fixed by #12170
Assignees

Comments

@bitgamma
Copy link
Member

bitgamma commented Feb 2, 2021

Bug Report

Problem

When signing a typed message, the chain ID is part of the message being signed. If this differs from the currently selected network, hashing the message fails (correctly). However this failure is not caught/shown anywhere and the user is still prompted to tap their card. At this point the process stalls, with the NFC prompt showing "Processing" forever. The user can only cancel, but likely will have no idea why this happens.

If the chain id matches the current network everything works normally.

Additional Information

Test on release 1.10.1, develop branch from 02.02.2021 and PR11540. PR11540 tested on iOS as well.

@bitgamma
Copy link
Member Author

bitgamma commented Feb 2, 2021

/cc @guylouis @gravityblast

@bitgamma
Copy link
Member Author

bitgamma commented Feb 5, 2021

@churik yes this is probably related. I will investigate those issues together

@churik
Copy link
Member

churik commented Feb 5, 2021

actually I deleted comment because after 3d attempt I could login normally, so not sure what happened. also will investigate from my side

@bitgamma
Copy link
Member Author

turned out to be more of an UX problem, I updated the description accordingly. I also separated the other issue which I was investigating together with this since they turned out not to be related.

@bitgamma bitgamma changed the title signing typed data on simpledapp.eth does not work with Keycard signing typed data with wrong chain ID fails without proper error message Feb 17, 2021
@bitgamma bitgamma self-assigned this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants