-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes iOS crashes at the end of the onboarding flow #16560
Comments
Adding to 1.24 but feel free to move it to 1.25. |
@qoqobolo for crashes we need the unfiltered logcat unfortunately, would you be able to provide one for the session? |
Thank you, |
@cammellos hmm, we haven't experienced any crashes on android. |
No, I meant replicating on Android, since it looks like a status-go issue (generally those are the ones that crashes the device in this way) |
I'm able to use xcode to run status now, so i'd like to take a look at this one |
hi @qfrank, thank you! During the release testing, we noticed that the crash happens much less often, but it still happens sometimes (randomly). |
Hi @qoqobolo , i'm unable to reproduce it during 10+ profiles created |
@pavloburykh could you share a PR link where you reproduced the crash today, please? |
|
after installed it , created bunch of profiles(20+) but still not able to reproduce it ): I did nothing else except simply switch the bottom tab after (Enable notifications -> Start using Status) each time , did i miss something? cc @pavloburykh |
@qfrank everything is correct. This is just a weird random crash which is hard to reproduce. |
@qfrank I have just reproduced IOS crash on fresh installed latest build from this PR #16630 Here are the logs, if they will be helpful |
@pavloburykh - Can you try the build from #16741 and see if you could encounter the crash? We are trying a new lib If any native (module) exception occurred, it will show this screen instead of crashing immediately. It will also try to send the log via email. Just a trial and error. |
hi @smohamedjavid Thank you! As I will be off during next week, someone from QA team will try the build (cc @qoqobolo @VolodLytvynenko). Although, it will be quite difficult to catch the crash as it happens randomly. |
I'm still unable to reproduce this crash when creating profile ... just removed my assignment, feel free to assign it to yourself , but i will keep an eye on it to see if i can reproduce it 🙂 |
Hey @smohamedjavid, here is the error I got: The app crashed on the first few attempts (3 or 4 times). Then it stopped crashing. On those first attempts, I enabled touch ID, then turned it off on onboarding, and the app stopped crashing. |
i was using iphone xs max (ios 16.1, physical device), i enabled face ID @qoqobolo |
Seems like for @VolodLytvynenko and @churik that's also reproducible even without enabling biometric id. Also, @VolodLytvynenko faced the issue of getting stuck on the "Keys saved" screen and the inability to log in (which I mentioned yesterday on retro) on Android as well. So it looks like these issues are unrelated. @Samyoul tagging you here since you wanted to take a look at this as well. |
The issue of getting stuck on the "Keys saved" screen is quite rare, but today I faced it again on the Android emulator. Here are the logcat logs: |
Just sharing my findings. Last week, while trying to reproduce this issue, @qfrank encountered a crash on the login page in iOS. When going through the logs, we discovered that the crash is possibly due to the We didn't conclude anything as we are not sure this will be the root cause of the crash encountered by the QA team. From the logs given by @VolodLytvynenko:
com.facebook.react.uimanager.IllegalViewOperationException: ViewManager for tag 213 could not be found.
at com.facebook.react.uimanager.NativeViewHierarchyManager.resolveViewManager(NativeViewHierarchyManager.java:111)
at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:138)
at com.facebook.react.uimanager.UIImplementation.synchronouslyUpdateViewOnUIThread(UIImplementation.java:305)
at com.swmansion.reanimated.NodesManager.updateProps(NodesManager.java:590)
at com.swmansion.reanimated.NativeProxy.updateProps(NativeProxy.java:185)
at com.swmansion.reanimated.NativeProxy$AnimationFrameCallback.onAnimationFrame(Native Method)
at com.swmansion.reanimated.NodesManager.onAnimationFrame(NodesManager.java:275)
at com.swmansion.reanimated.NodesManager.access$000(NodesManager.java:67) It seems like the crash is caused due to the I saw a lot of crashes reported on the library GH: https://github.com/software-mansion/react-native-reanimated/issues. We use So, our primary suspect is the |
|
getting stuck on the "Keys saved" screen is a separate issue, i will push a fix for it today cc @qoqobolo @VolodLytvynenko |
Got one crash on iOS simulator (at the end of onboarding flow) the other day, caused by reanimated i guess
|
Thanks, @yqrashawn . It seems to resemble this open issue on the reanimated repository I'm not sure how far along we are with upgrading the reanimated library 🤔. |
regarding to this comment issue, after tried reproducing with xcode, i found it point to |
I tested the flow (sync flow) with this PR #17241 , and I tried it four times in a row without any crash. So, I can confirm that the issue is related to the Reanimated version. After merging this PR, hopefully, it will resolve the sync and onboarding crash hopefully |
Will be fixed by #17241 |
Assigning myself because we need not do anything and this will be fixed in the RN upgrade PR. |
fixed here : #17241 |
Bug Report
Problem
We've been experiencing random crashes on iOS for some time, but these particular crashes on creating a profile have become more common (but still not always reproducible).
More often it crashes right after creating a profile (after pressing
Start using Status
and opening the home screen), sometimes on theEnable notifications
screen.IMG_1575.MP4
Unfortunately, we do not have exact steps to reproduce.
Logs:
geth.log
Status.log
Reproduction
Start using Status
Additional Information
The text was updated successfully, but these errors were encountered: