user avatar broken in preview-list

[ulisesmac]

Bug Report

Problem

With the recent changes to the user-avatar component (quo2.components.avatars.user-avatar.view), the preview-list component is broken.

Expected behavior

Correctly display the avatars.

Actual behavior

Nothing but the counter is displayed

Reproduction

1. Navigate to quo2 preview screens -> list-items -> preview-lists
2. The component is not displayed correctly

Additional Information

• Operating System: Android

This issue has been rised because the PR for context-tags relies on the user-avatar component for some variants, after rebasing on the latest changes of user-avatar, the component layout have changed and is no longer displayed.

Probably the causing PR is

• feat: render all avatars using media server #16193

[smohamedjavid]

The props for the user avatar component need to be updated.
There are no issues with the components.
I fixed it in the PR #17051 👍

[ulisesmac]

The props for the user avatar component need to be updated. There are no issues with the components. I fixed it in the PR #17051 👍

@smohamedjavid Has the user-avatar component changed to match figma API?
if not, I think the user-avatar should keep its old API calls as valid instead of updating every component using it.

Also, the uses should have been updated in the same issue where the API changed (or a direct follow-up).

[smohamedjavid]

@smohamedjavid Has the user-avatar component changed to match figma API?
if not, I think the user-avatar should keep its old API calls as valid instead of updating every component using it.

Also, the uses should have been updated in the same issue where the API changed (or a direct follow-up).

Apologies @ulisesmac,

I was reading the issue in the context of the Preview-list component.

You are right. The user avatar component is yet to be updated to match Figma APIs. The user avatar component broken is NOT due to the preview-list component.

The recent changes #16193 on User Avatar have refactored the source prop of the image component inside the user-avatar component. The mock images we pass from resources (for preview) are rendered trying to render as a remote image (through :uri) and fail.

I have added another check in user-avatar to bring back support to render the mock images for testing purposes 👍

PR: #17051 / Commit: 2ee7585

[ulisesmac]

@smohamedjavid Has the user-avatar component changed to match figma API?
if not, I think the user-avatar should keep its old API calls as valid instead of updating every component using it.

Also, the uses should have been updated in the same issue where the API changed (or a direct follow-up).

Apologies @ulisesmac,

I was reading the issue in the context of the Preview-list component.

You are right. The user avatar component is yet to be updated to match Figma APIs. The user avatar component broken is NOT due to the preview-list component.

The recent changes #16193 on User Avatar have refactored the source prop of the image component inside the user-avatar component. The mock images we pass from resources (for preview) are rendered trying to render as a remote image (through :uri) and fail.

I have added another check in user-avatar to bring back support to render the mock images for testing purposes 👍

PR: #17051 / Commit: 2ee7585

Thank you so much! :)
@smohamedjavid

[smohamedjavid]

Closing the issue as it's fixed in PR: #17051