Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QR code scanner screen #17574

Closed
ajayesivan opened this issue Oct 6, 2023 · 10 comments · Fixed by #18677
Closed

Implement QR code scanner screen #17574

ajayesivan opened this issue Oct 6, 2023 · 10 comments · Fixed by #18677
Assignees
Milestone

Comments

@ajayesivan
Copy link
Contributor

Design: https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?type=design&node-id=451-18994&mode=dev

Currently, we are using a minimal version of the camera for QR code scanning.

Reported in design feedback here

@churik
Copy link
Member

churik commented Nov 27, 2023

cross-linking with #17658 - would be awesome to fix it in one PR

@alwx alwx self-assigned this Nov 28, 2023
@clauxx
Copy link
Member

clauxx commented Jan 9, 2024

Fixed by #17767

@clauxx clauxx closed this as completed Jan 9, 2024
@alwx
Copy link
Contributor

alwx commented Jan 10, 2024

@clauxx why did you close it?

This is what currently happens when you click the scan QR button:
Screenshot 2024-01-10 at 12 59 19

@alwx alwx reopened this Jan 10, 2024
@clauxx
Copy link
Member

clauxx commented Jan 10, 2024

@alwx Right, I guess we should re-define the scope of the task (or have a different one) as the scanner was updated according to the design already (see screenshot from the "add contact" flow from messages).

0

@alwx
Copy link
Contributor

alwx commented Jan 10, 2024

Yes, I will check it out today and update the issue.

@alwx
Copy link
Contributor

alwx commented Jan 24, 2024

@jo-mut wait, but you are basically doing the same in #18604? Why?

@jo-mut
Copy link
Contributor

jo-mut commented Jan 24, 2024

@alwx I am aware you are working on this, so I do not intend to merge the draft pr. I just created it incase you can pick up something from it as the screen as @J-Son89 and I had paired on this. Knowledge sharing. Thats all

@jo-mut
Copy link
Contributor

jo-mut commented Jan 31, 2024

@alwx looking at the scope of work particularly on this screen I think we can split this into separate issues

I understand in some case like scanning the QR for community, channels, profiles have not been implemented. I think its okay to limit the scope of this to just adding the qr-code scan screen and follow it up with a different pr for the differnent scenarios specified in the figma. wdyt?

@alwx
Copy link
Contributor

alwx commented Feb 1, 2024

@jo-mut I think the overhead of creating different issues for different types of scanning will be bigger than doing it all in one issue, to be honest. There are certain scenarios that are a bit more complicated but most are limited to just calling one function once the QR is scanned.
Anyway, I'll update it today if my opinion changes after taking a closer look and implementing the rest of the scenarios.

@alwx
Copy link
Contributor

alwx commented Feb 5, 2024

Encountered a bit of an issue with contact scanning and I think I will limit the PR only to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants