App crashes after recover of any user #18092

pavloburykh · 2023-12-06T13:12:58Z

This bug is not in our develop yet. So it should be reproduced in the builds looking at current go develop.

You can reproduce the bug in PR builds that include new go version, for example #17941 or #18069

Steps:

Recover any user
See if app is not crashing after recovery

Actual result: app crashes

Status-debug-logs (88).zip

telegram-cloud-document-2-5442983136206012091.mp4

Expected result: app does not crash

Additional Information

Status version: nightly
Operating System: Android, iOS

cammellos · 2023-12-06T13:21:14Z

INFO [11-29|10:12:55.686|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"
INFO [11-29|10:12:55.686|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"
INFO [11-29|10:12:55.686|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"
INFO [11-29|10:12:55.687|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"
INFO [11-29|10:12:55.687|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"
INFO [11-29|10:12:55.687|github.com/status-im/status-go/protocol/messenger_mailserver_cycle.go:270]                                          connecting error                         eerr="tcp check timeout: I/O timeout"

Don't think it's causing the crash, but worth maybe having a look, @richard-ramos

pavloburykh · 2023-12-06T13:25:52Z

@cammellos here is a logcat
crashlog_061223.log.zip

cammellos · 2023-12-06T13:27:21Z

12-06 14:36:15.474 19241     0 E Go      : [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x7998307748]
12-06 14:36:15.474 19241     0 E Go      : 
12-06 14:36:15.474 19241     0 E Go      : goroutine 28293 [running]:
12-06 14:36:15.474 19241     0 E Go      : github.com/status-im/status-go/services/wallet/transfer.(*loadBlocksAndTransfersCommand).fetchHistoryBlocks(0x40062c2480, {0x4003be1e78?, 0x4?}, 0x4?, {0x8a, 0x13, 0x12, 0x24, 0x6b, 0x98, ...}, ...)
12-06 14:36:15.474 19241     0 E Go      : 	github.com/status-im/status-go/services/wallet/transfer/commands_sequential.go:803 +0x2d8
12-06 14:36:15.475 19241     0 E Go      : github.com/status-im/status-go/services/wallet/transfer.(*loadBlocksAndTransfersCommand).Run(0x40062c2480, {0x7998e3d818, 0x4006205340})
12-06 14:36:15.475 19241     0 E Go      : 	github.com/status-im/status-go/services/wallet/transfer/commands_sequential.go:745 +0x3c4
12-06 14:36:15.475 19241     0 E Go      : github.com/status-im/status-go/services/wallet/async.InfiniteCommand.Run({0x4006847601?, 0x4006726d00?}, {0x7998e3d818, 0x4006205340})
12-06 14:36:15.475 19241     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:72 +0x40
12-06 14:36:15.475 19241     0 E Go      : github.com/status-im/status-go/services/wallet/async.(*Group).Add.func1()
12-06 14:36:15.475 19241     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:101 +0x34
12-06 14:36:15.475 19241     0 E Go      : created by github.com/status-im/status-go/services/wallet/async.(*Group).Add
12-06 14:36:15.475 19241     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:100 +0x8c
12-06 14:36:15.475 19241 20645 E GoLog   : panic: runtime error: invalid memory address or nil pointer dereference
12-06 14:36:15.475 19241 20645 E GoLog   : [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x7998307748]

cammellos · 2023-12-06T13:38:09Z

@pavloburykh can you ask people to rebase against status-go develop? the code has changed since then

pavloburykh · 2023-12-06T14:33:31Z

@pavloburykh can you ask people to rebase against status-go develop? the code has changed since then

@cammellos unfortunately rebasing didn't help. I have checked latest builds here #18069 and still facing the crash.

Attaching fresh logcat if needed.

crashlog_111333.log.zip

cammellos · 2023-12-06T14:50:36Z

12-06 16:26:11.140 21775     0 E Go      : goroutine 1973 [running]:
12-06 16:26:11.140 21775     0 E Go      : github.com/status-im/status-go/services/wallet/transfer.(*loadBlocksAndTransfersCommand).fetchHistoryBlocks(0x4003f54c60, {0x4002671e78?, 0x4?}, 0x4?, {0x4, 0x88, 0x34, 0x26, 0x6d, 0x47, ...}, ...)
12-06 16:26:11.140 21775     0 E Go      : 	github.com/status-im/status-go/services/wallet/transfer/commands_sequential.go:821 +0x2d8
12-06 16:26:11.140 21775     0 E Go      : github.com/status-im/status-go/services/wallet/transfer.(*loadBlocksAndTransfersCommand).Run(0x4003f54c60, {0x7cf5213af8, 0x4003ec3b00})
12-06 16:26:11.140 21775     0 E Go      : 	github.com/status-im/status-go/services/wallet/transfer/commands_sequential.go:763 +0x3c4
12-06 16:26:11.140 21775     0 E Go      : github.com/status-im/status-go/services/wallet/async.InfiniteCommand.Run({0x0?, 0x4003f398f0?}, {0x7cf5213af8, 0x4003ec3b00})
12-06 16:26:11.140 21775     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:72 +0x40
12-06 16:26:11.140 21775     0 E Go      : github.com/status-im/status-go/services/wallet/async.(*Group).Add.func1()
12-06 16:26:11.141 21775     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:101 +0x34
12-06 16:26:11.141 21775     0 E Go      : created by github.com/status-im/status-go/services/wallet/async.(*Group).Add
12-06 16:26:11.141 21775     0 E Go      : 	github.com/status-im/status-go/services/wallet/async/async.go:100 +0x8c

cammellos · 2023-12-06T14:51:28Z

@IvanBelyakoff could you have a look at the issue above please?

siddarthkay · 2023-12-06T14:51:39Z

fetchHistoryBlocks status-im/status-go@82185b5#diff-32cceb00b8d06fb3f28df6024d1e28c526c6215bb329976d5fed6a4c5fffcf4cR1102 code was touched in status-im/status-go#4386

cammellos · 2023-12-06T16:35:29Z

@IvanBelyakoff will take a look at this tomorrow morning. Thank you!

IvanBelyakoff · 2023-12-07T07:26:11Z

Guys, sorry for the issue. Here is a quick fix status-im/status-go#4433
For me no crash on recovery on desktop.
@pavloburykh @cammellos

pavloburykh · 2023-12-07T09:25:49Z

Guys, sorry for the issue. Here is a quick fix status-im/status-go#4433 For me no crash on recovery on desktop. @pavloburykh @cammellos

@IvanBelyakoff thank you for the fix! Unfortunately still reproducing issue when recovering user with tokens. I have left the details here #18110 (comment)

IvanBelyakoff · 2023-12-07T11:51:35Z

I updated the PR, please check it once again. There was another crash in a different place

cammellos · 2023-12-08T11:40:28Z

@pavloburykh removing release blocker label, as this is not on 1.26 branch

pavloburykh · 2023-12-11T07:29:25Z

Fixed by #18110

pavloburykh added onboarding bug Release Blocker labels Dec 6, 2023

pavloburykh added this to the 1.26.0 - Alpha milestone Dec 6, 2023

VolodLytvynenko mentioned this issue Dec 6, 2023

fix: 1:1 chat concerns #17795

Merged

pavloburykh mentioned this issue Dec 6, 2023

PR to fix general channel forever loading issue when joining an open community #18069

Closed

siddarthkay mentioned this issue Dec 7, 2023

chore: point to recovery account fix in status-go #18110

Closed

cammellos modified the milestones: 1.26.0 - Alpha, 1.27.0 - Alpha Dec 8, 2023

pavloburykh closed this as completed Dec 11, 2023

ilmotta removed the bug label Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App crashes after recover of any user #18092

App crashes after recover of any user #18092

pavloburykh commented Dec 6, 2023

cammellos commented Dec 6, 2023

pavloburykh commented Dec 6, 2023

cammellos commented Dec 6, 2023

cammellos commented Dec 6, 2023

pavloburykh commented Dec 6, 2023 •

edited

Loading

cammellos commented Dec 6, 2023

cammellos commented Dec 6, 2023

siddarthkay commented Dec 6, 2023 •

edited

Loading

cammellos commented Dec 6, 2023

IvanBelyakoff commented Dec 7, 2023

pavloburykh commented Dec 7, 2023

IvanBelyakoff commented Dec 7, 2023

cammellos commented Dec 8, 2023

pavloburykh commented Dec 11, 2023

App crashes after recover of any user #18092

App crashes after recover of any user #18092

Comments

pavloburykh commented Dec 6, 2023

Additional Information

cammellos commented Dec 6, 2023

pavloburykh commented Dec 6, 2023

cammellos commented Dec 6, 2023

cammellos commented Dec 6, 2023

pavloburykh commented Dec 6, 2023 • edited Loading

cammellos commented Dec 6, 2023

cammellos commented Dec 6, 2023

siddarthkay commented Dec 6, 2023 • edited Loading

cammellos commented Dec 6, 2023

IvanBelyakoff commented Dec 7, 2023

pavloburykh commented Dec 7, 2023

IvanBelyakoff commented Dec 7, 2023

cammellos commented Dec 8, 2023

pavloburykh commented Dec 11, 2023

pavloburykh commented Dec 6, 2023 •

edited

Loading

siddarthkay commented Dec 6, 2023 •

edited

Loading