Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user is not navigated to the save address screen after the eth QR is scanned by universal scanner #18933

Closed
VolodLytvynenko opened this issue Feb 21, 2024 · 3 comments
Labels

Comments

@VolodLytvynenko
Copy link
Contributor

this issue implementation should be started after the #18928 is merged

Steps:

  1. Open universal scan
  2. Scan the ETH address
  3. Select 'save address' option in the opened bottom sheet

Actual result:

The user is navigated to the address sсreen

Expected result:

The user is navigated to 'save address' flow
https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&mode=design&t=N2xV3WFXo87lNZlk-0

Aligned it with the design team here

@VolodLytvynenko
Copy link
Contributor Author

Hey @shivekkhurana Jamie asked here to tag you after this issue creation

@J-Son89
Copy link
Contributor

J-Son89 commented Feb 21, 2024

Hey @shivekkhurana Jamie asked here to tag you after this issue creation

thanks @VolodLytvynenko - yes, whoever works on this should align with @alwx (implemented generic scanner)
and @shivekkhurana - currently working on the save address feature.
This issue will be blocked until the save address feature is complete 👍

@VolodLytvynenko
Copy link
Contributor Author

fixed in #19250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants