-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Metamask address QRs #19986
Comments
After discussing this issue with John it needs to be updated. Hold on... |
put the label "blocked" when it is under the discussion |
Issue discussed with John and updated. |
cc @J-Son89 should it be included in 2.30? |
It does seem like something worth having, let's put it lower priority than the |
Yes, I think it is required feature to be honest, agreed |
postponed due to limited capacity for 2.30 |
User Story
As a Status app user, I want to be able to scan Metamask QR addresses, so I can send assets or save the address, if Status supports the network.
Description
Metamask stores addresses in QR codes with the following format:
ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2@0xa
ethereum: - prefix described in EIP-67
0xa - chain ID suffix described in EIP-155
Since Status addresses do not include these parts, we need to convert the data from Metamask QR addresses to a format our app can work with for sending, saving, and editing network preferences.
Conversion
ethereum: - prefix should be ignored and removed on our side
Status addresses follow the EIP-3770 format, which maps hexadecimal chain IDs to readable chain prefixes.
More networks: chains_mini.json file on chainid.network
After converting, ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2@0xa should become oeth:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2
This conversion should happen in all instances of scanning addresses, such as
It should be implemented on all supported platforms.
If the address contains an unsupported network, the user should receive an error "Address contains unsupported network" Users should not be able to save addresses with unsupported network prefixes to avoid problems in the send flow and sending assets to wrong networks.
Implementation.
Acceptance Criteria
Future Steps
Consider supporting Metamask's "Payment request" QR format including additional data like requested amount and token ID.
The text was updated successfully, but these errors were encountered: