Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quo - Settings/Data Item: Editable Variant #20505

Closed
Tracked by #19997
ajayesivan opened this issue Jun 19, 2024 · 0 comments · Fixed by #20656
Closed
Tracked by #19997

Quo - Settings/Data Item: Editable Variant #20505

ajayesivan opened this issue Jun 19, 2024 · 0 comments · Fixed by #20656

Comments

@ajayesivan
Copy link
Contributor

Design

Screenshot 2024-06-19 at 10 36 48

Figma: https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=38746-40049&m=dev

Description

The Data Item component already exists, and we need to add a new :description :editable variant. While we aim to match the API as closely as possible with Figma, the current implementation uses a different prop for this, namely subtitle-type. For now, I would suggest keeping the existing prop name and adding the new variant to avoid unnecessary issues with existing usages. However, if you decide to update the API, please make sure to update all usages accordingly.

Additionally, it would be great if we could add the component schema and tests along with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants