Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎛️ ⏩ Custom Option Menu for TX Parameters on SEND Flow #21020

Closed
2 tasks
vkjr opened this issue Aug 12, 2024 · 0 comments · Fixed by #21657
Closed
2 tasks

🎛️ ⏩ Custom Option Menu for TX Parameters on SEND Flow #21020

vkjr opened this issue Aug 12, 2024 · 0 comments · Fixed by #21657
Assignees
@vkjr
Labels
wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Milestone
2.32.0

Comments

@vkjr
Copy link
Contributor

vkjr commented Aug 12, 2024 •
edited by shivekkhurana
Loading

Description

#21019 implments presets for tx parameters. For this ticket, we want to implement the custom options menu.
The scope of the ticket is just the menu UI. The actual setting for custom options will be handled in separate tickets.

Figma Link: https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17671-201810&t=Gll0qjdreBGQzaWK-4

Implementation

Description Screenshot
Custom Anchor Point in TX Params Settings Menu Image
Clicking the button should open this menu Image

Acceptance Criteria

  • The txn summary screen has a button to edit tx params. Clicking that button should open the menu in with "Custom Anchor Point" (check screen above)
  • Clicking the custom button should open the second menu

Notes

This menu UI only ticket was made so that the actual settings can be worked by two CCs in parallel.
The implementation tickets are: #21023 & #21024

Future Steps

Once this ticket is merged, the actual implementation UI will be made on top )
@vkjr vkjr added the wallet: TX settings Send screen transaction settings (nonce, limits) label Aug 12, 2024
@vkjr vkjr added this to the 2.31.0 Beta milestone Aug 12, 2024
This was referenced Aug 12, 2024
Open
Closed
@churik churik added the wallet-core Issues for mobile wallet team label Aug 28, 2024
@churik churik modified the milestones: 2.31.0 Beta, 2.32.0 Beta Sep 23, 2024
@shivekkhurana shivekkhurana changed the title Set nonce, tx settings screen 🎛️ ⏩ Custom Option Menu for TX Parameters on SEND Flow Nov 4, 2024
@vkjr vkjr self-assigned this Nov 4, 2024
@friofry friofry mentioned this issue Nov 19, 2024
Open
@vkjr vkjr mentioned this issue Nov 20, 2024
Merged
@vkjr vkjr moved this to Code Review in Status Desktop/Mobile Board Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkjr vkjr

Labels
wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

Custom Option Menu for TX Parameters on SEND Flow status-im/status-mobile
2 participants
@churik @vkjr