Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Not visible status bar on light theme #21101

Closed
mariia-skrypnyk opened this issue Aug 21, 2024 · 3 comments · Fixed by #21105
Closed

[iOS] Not visible status bar on light theme #21101

mariia-skrypnyk opened this issue Aug 21, 2024 · 3 comments · Fixed by #21105
Assignees

Comments

@mariia-skrypnyk
Copy link

Bug Report

Actual behavior

Screenshot 2024-08-21 at 13 05 39

Expected behavior

Screenshot 2024-08-21 at 13 06 16

Reproduction

  1. Login to app

Additional Information

  • Status version: release 2.30
  • Operating System: iOS
@ilmotta
Copy link
Contributor

ilmotta commented Aug 21, 2024

Just checked in iOS in a release build and the bug indeed exists. I think this is an important one to fix for the release. Probably a very recent regression.

@Parveshdhull do you happen to have any idea why this problem is happening? Could you take a look for us? 🙏🏼

@ilmotta
Copy link
Contributor

ilmotta commented Aug 21, 2024

The bug exists in Android too.

@Parveshdhull Parveshdhull self-assigned this Aug 21, 2024
@Parveshdhull
Copy link
Member

(rf/reg-fx :set-root
(fn [[root-id theme]]
(let [[status-bar-theme] (get-status-nav-color root-id theme)
root (get (roots/roots status-bar-theme) root-id)]
(dismiss-all-modals)
(rf/dispatch [:theme/switch {:view-id root-id}])

We update the right theme for root in line 77, but its too late and root at line 72 has wrong value.

  1. Solution One: Always manually call :theme/switch before :init-root at all places.
  2. Solution Two: Instead of init-root have an event :update-theme-and-init-root. And in this even first we dispatch theme change, then init-root

cc @ilmotta @flexsurfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants