Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain Cuties does not load inside Status #3824

Closed
flexsurfer opened this issue Apr 10, 2018 · 19 comments
Closed

Blockchain Cuties does not load inside Status #3824

flexsurfer opened this issue Apr 10, 2018 · 19 comments

Comments

@flexsurfer
Copy link
Member

flexsurfer commented Apr 10, 2018

https://blockchaincuties.co/ does not load inside Status

Blockchain Cuties is the new collectible crypto game with adventures where you get to play with puppies, lizards, bear cubs, cats and other real and fantasy creatures alike.
@flexsurfer flexsurfer self-assigned this Apr 10, 2018
@chadyj chadyj added the dapp label Apr 10, 2018
@flexsurfer flexsurfer removed their assignment May 7, 2018
@flexsurfer
Copy link
Member Author

image

@flexsurfer
Copy link
Member Author

looks like dapp bug

@rachelhamlin
Copy link
Contributor

Is there some connection to web3 issues? I'm able to load Blockchain Cuties in other browsers.

@jeluard
Copy link
Contributor

jeluard commented May 14, 2018

Right hard to track down without more context. @rachelhamlin Maybe we could try to reach out to them and try to collaborate to fix this?

@rachelhamlin
Copy link
Contributor

@jeluard sure, I'll reach out. Is there anything in particular we'd like to know right now?

@jeluard
Copy link
Contributor

jeluard commented May 14, 2018

@rachelhamlin Not really. We don't have much info. A contact with a dev would be great!

@MightyBo
Copy link

Hello guys, I'm Blockchain Cuties producer. Thanks for reaching out.
We'll look into this from our side right away.

For further issues you can contact us via: social@blockchaincuties.co

@rachelhamlin
Copy link
Contributor

@MightyBo hey Vladimir, big thanks for looking into this! We have another webview issue that may be related, so if you rule out problems on your side, we'll know we need more focus there.

@rachelhamlin rachelhamlin added this to the Q3 Browser Fixes milestone Jun 27, 2018
@status-github-bot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@status-github-bot
Copy link

This issue has been automatically closed. Please re-open if this issue is important to you.

@flexsurfer flexsurfer reopened this Oct 2, 2018
@status-github-bot status-github-bot bot removed the stale label Oct 2, 2018
@flexsurfer
Copy link
Member Author

Need to be fixed

@flexsurfer
Copy link
Member Author

flexsurfer commented Dec 6, 2018

interesting that it's loaded fine with privacy mode enabled, need to be investigated more

@flexsurfer
Copy link
Member Author

flexsurfer commented Dec 7, 2018

so the problem in web3 library, status injects web3 library and imports web3.0.20.x , but this dapp also imports web3.1.0.0, and there is a conflict in web3 versions, so this dapp will work fine in web3 opt-in mode, because we don't import web3 library in this mode anymore

@rachelhamlin
Copy link
Contributor

Thanks for looking into it @flexsurfer. Two questions:

  1. Do you think this has been the issue all along?
  2. Is there any action for us to take?

@flexsurfer
Copy link
Member Author

  1. yes, we import web3.0.20.x from the beginning, and there were no changes
  2. i don't see any simple solution, we can research it more, but we want to enable privacy mode by default soon, so there we won't import web3 library anymore, and because we know only one dapp which has this issues maybe it's not worth it

@rachelhamlin
Copy link
Contributor

@flexsurfer agreed. Closing this issue because it affects just one DApp that we know of, and will be irrelevant once EIP1102 is enforced.

@MightyBo
Copy link

Guys, common, this issue is from April 2018, you weren't able to address it in time and now you're closing it? Blockchain Cuties is not "just one DApp", it's usually #2 game on the Ethereum market according to dappradar and always in Top 5. We even did a Status.im item set in the game.
This is super silly. Fix it already, please.

@jeluard
Copy link
Contributor

jeluard commented Dec 10, 2018

@MightyBo Have you migrated to EIP 1102? This is the proper solution has the older method will be deprecated soon. Status supports this already.

@MightyBo
Copy link

@MightyBo Have you migrated to EIP 1102? This is the proper solution has the older method will be deprecated soon. Status supports this already.

We didn't migrate yet and won't be able to do so until early-mid January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants