Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to mark all messages as read #5394

Closed
lukaszfryc opened this issue Aug 6, 2018 · 11 comments
Closed

Allow to mark all messages as read #5394

lukaszfryc opened this issue Aug 6, 2018 · 11 comments
Labels
feature feature requests

Comments

@lukaszfryc
Copy link
Contributor

lukaszfryc commented Aug 6, 2018

Description

Type: Feature

Summary:
Each of unread message has to be seen in order for the unread message counter to disappear. This can be an issue when you have hundreds of unread messages and you do not want to scroll to see them all. That's why we want to introduce unread messages badge with "X" button that marks all messages as read:

Design: https://app.zeplin.io/project/5a55d587ba304eed4d2c942f/screen/5b1a79ae98f9b848590fb930

Expected behavior

  • Badge appreas if there are some unread messages. The counter changes while the user scrolls up to read messages
  • Clicking on the badge takes the user to the first unread message
  • User can mark all messages as read by clicking "X" on the badge

Actual behavior

User needs to see all messages manually for unread message counter to disappear.

Additional Information

  • Status version: 0.9.24
  • Operating System: Android, iOS
@lukaszfryc lukaszfryc added chat feature feature requests labels Aug 6, 2018
@lukaszfryc
Copy link
Contributor Author

This issue has been mentioned couple of times on Instabug.

@lukaszfryc
Copy link
Contributor Author

There are couple of solutions to this problem. One which is very simple is to have "Mark all messages as read" button in chat options. The other can be to scroll to the first unread message when a chat is opened and show visual indicator for it similar to what Slack does:

image

@errorists I think we need design your input here :) Please check #4691 which is related.

@errorists
Copy link
Contributor

errorists commented Aug 7, 2018

@lukaszfryc are you aware of this design zpl.io/aN0ZKWQ ? Can't find a GH issue for it, but it follows the Slack route of marking messages as read and is ready for implementation.

@lukaszfryc
Copy link
Contributor Author

@errorists this design looks great and I think it has good UX. We should definitely make tappable area for "X" big enough to easily click it. I believe it will be used often.

@errorists
Copy link
Contributor

@lukaszfryc I'll be revisiting those snackbars sometime in the near future as they seem to cause some issues, I'll see what can be done about the tappable area to reach the sensible minimum of 44x44pts

@lukaszfryc
Copy link
Contributor Author

lukaszfryc commented Oct 11, 2018

More people complain about this Instabug including @jarradh.

@yenda or @janherich, maybe you could work on this task?

@lukaszfryc
Copy link
Contributor Author

lukaszfryc commented Oct 11, 2018

Alternatively we can just mark all messages as read when chat is opened. It's easier to implement but it will not allow us to keep track of new messages in channels. That's why the best solution is https://app.zeplin.io/project/5a55d587ba304eed4d2c942f/screen/5b1a79ae98f9b848590fb930

Zeplin
Collaboration app for UI designers and frontend developers

@lukaszfryc
Copy link
Contributor Author

I updated the description of the issue. @errorists could you double check it to see if I got the behaviour of the badge right?

@rcullito rcullito self-assigned this Dec 3, 2018
@oskarth
Copy link
Contributor

oskarth commented Dec 12, 2018

Is this really a blocker? I understand it'd be nice but seems like it can be cut from scope.

cc @rachelhamlin

@errorists
Copy link
Contributor

This task is superseded by #6375

@oskarth
Copy link
Contributor

oskarth commented Feb 18, 2019

Closing as there's a new issue for this.

@oskarth oskarth closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

5 participants