-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to mark all messages as read #5394
Comments
This issue has been mentioned couple of times on Instabug. |
There are couple of solutions to this problem. One which is very simple is to have "Mark all messages as read" button in chat options. The other can be to scroll to the first unread message when a chat is opened and show visual indicator for it similar to what Slack does: @errorists I think we need design your input here :) Please check #4691 which is related. |
@lukaszfryc are you aware of this design zpl.io/aN0ZKWQ ? Can't find a GH issue for it, but it follows the Slack route of marking messages as read and is ready for implementation. |
@errorists this design looks great and I think it has good UX. We should definitely make tappable area for "X" big enough to easily click it. I believe it will be used often. |
@lukaszfryc I'll be revisiting those snackbars sometime in the near future as they seem to cause some issues, I'll see what can be done about the tappable area to reach the sensible minimum of 44x44pts |
More people complain about this Instabug including @jarradh. @yenda or @janherich, maybe you could work on this task? |
Alternatively we can just mark all messages as read when chat is opened. It's easier to implement but it will not allow us to keep track of new messages in channels. That's why the best solution is https://app.zeplin.io/project/5a55d587ba304eed4d2c942f/screen/5b1a79ae98f9b848590fb930
|
I updated the description of the issue. @errorists could you double check it to see if I got the behaviour of the badge right? |
Is this really a blocker? I understand it'd be nice but seems like it can be cut from scope. |
This task is superseded by #6375 |
Closing as there's a new issue for this. |
Description
Type: Feature
Summary:
Each of unread message has to be seen in order for the unread message counter to disappear. This can be an issue when you have hundreds of unread messages and you do not want to scroll to see them all. That's why we want to introduce unread messages badge with "X" button that marks all messages as read:
Design: https://app.zeplin.io/project/5a55d587ba304eed4d2c942f/screen/5b1a79ae98f9b848590fb930
Expected behavior
Actual behavior
User needs to see all messages manually for unread message counter to disappear.
Additional Information
The text was updated successfully, but these errors were encountered: