Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNT and emoji reactions #7118

Closed
yenda opened this issue Dec 17, 2018 · 1 comment
Closed

SNT and emoji reactions #7118

yenda opened this issue Dec 17, 2018 · 1 comment

Comments

@yenda
Copy link
Contributor

yenda commented Dec 17, 2018

Problem

As a user, I want to be able to react to a message by sending SNT to it
As a user, I want to react to a message with an emoji

Implementation

use https://github.com/instea/react-native-popup-menu or custom popup-menu

Design

Figma // Framer prototype

Implementation

  • SNT reactions should use a flow similar to the one of the /send command
  • SNT reactions require some mechanism to verify the transaction
  • investigate reaction schema vs having reaction string field storing reactions as edn in the message schema

Acceptance Criteria

  • user stories are implemented
@yenda yenda self-assigned this Dec 17, 2018
@yenda yenda changed the title MVP SNT and emoji reactions MVP 4 SNT and emoji reactions Dec 17, 2018
@yenda yenda added the chat label Dec 17, 2018
@yenda yenda changed the title MVP 4 SNT and emoji reactions MVP 5 SNT and emoji reactions Dec 21, 2018
@yenda yenda changed the title MVP 5 SNT and emoji reactions MVP 6 SNT and emoji reactions Jan 14, 2019
@rachelhamlin rachelhamlin changed the title MVP 6 SNT and emoji reactions SNT and emoji reactions Apr 23, 2020
@Samyoul
Copy link
Member

Samyoul commented Jul 9, 2020

Process flow

  • User selects a message and selects an emoji reaction
  • UI sends a JSON RPC method call to status-go
    • How does this RPC message get created?
    • Does UI set the content type of the message etc?
  • status-go receives RPC method call
  • status-go parses the RPC data and interprets the message to be sent via Waku
  • status-go saves outgoing message
    • Although the logic seems to save the chat, does this include the messages?
    • see protocol/persistence.go
  • status-go sends message to peers
  • peer receives message,
  • peer parses the message
  • peer saves the message
    • How are migrations generated?
    • Does the peer update the UI or does the UI request an update for new messages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants