-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7947] Feature: Blank out app preview screen when switching apps on m… #8009
Conversation
Tested only in iOS simulator so far |
Jenkins BuildsClick to see older builds (54)
|
100% of end-end tests have passed
Passed tests (48)Click to expand
|
Pull Request Checklist
|
100% of end-end tests have passed
Passed tests (48)Click to expand
|
Have we considered this approach? https://stackoverflow.com/questions/9822076/how-do-i-prevent-android-taking-a-screenshot-when-my-app-goes-to-the-background |
didn't know about this.. sounds more robust |
yep seems that on android we need to try https://developer.android.com/reference/android/view/Display.html#FLAG_SECURE |
Thanks @rasom @yenda for the pointers I barely got my development machine in order after having it being broken more than a week ago. I am hardly familiar with lower React-Native / Android development / Java areas, but this will give me a chance to get to know it Going to do the due diligence and make a proper implementation soon Please bare with me |
Changed the implementation as guided using FLAG_SECURE in android. Additionally, used SharedPreferences/NSUserDefaults to persist flag setting - additions are made to Status native-module. @corpetty includes bonus (user setting) as requested Tested in iOS Simulator and Android-avd:
Notes:
|
@mandrigin @rasom @yenda ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small changes, good job otherwise!
@mandrigin updated PR with suggested changes. Please note that at this point I am barely getting acquainted with Java and Objective-c and the implementation might still be sloppy. Hope the work is acceptable. If not, with feedback, still going to do what it takes. Those (Java/Obj-c) parts have mostly been an adaptation(with prior knowledge of languages other than those) of code found in the interwebs; with finally reading documentations in the past 24 hrs :p. Sorry about that and thanks for baring with me. Also definitely going to continue to spend some time acquiring knowledge on them for knowledge sake. |
94% of end-end tests have passed
Failed tests (3)Click to expand
Passed tests (46)Click to expand |
yes 'secure' flag is set @antdanchenko @churik help! looks like e2e tests are going to have to be updated for this one as well or the implementation is going to have to change if significant number of tests depend on capturing screenshot 🤔 |
@bitsikka maybe we can have this option behind a build flag somehow? so it is disabled for e2e? |
@bitsikka or, easier, it should be |
yes, it is I'll make it |
33% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (1) |
100% of end-end tests have passed
Passed tests (2)Click to expand
|
Thanks, @bitsikka! Tested IOS 11.4.1 (IPhone 7), Android 8 (LG V20):
|
…obile Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Fixes #7947
Notes: #8009 (comment)
status: ready