Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed #7948] Do not navigate back to chat when in a DApp #8014

Merged
merged 1 commit into from
May 2, 2019
Merged

[Fixed #7948] Do not navigate back to chat when in a DApp #8014

merged 1 commit into from
May 2, 2019

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Apr 22, 2019 •
edited by 0xc1c4da
Loading

fixes #7948

Summary

Do not navigate back to chat when in a DApp

status: ready

@jeluard jeluard self-assigned this Apr 22, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Apr 22, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ db10e6a #1 2019-04-22 13:26:10 ~7 min ios 📄 log
❌ db10e6a #1 2019-04-22 13:34:01 ~15 min linux 📄 log
✔️ db10e6a #1 2019-04-22 13:35:18 ~16 min macos 📦 dmg
✔️ db10e6a #1 2019-04-22 13:41:16 ~22 min android 📦 apk
✔️ db10e6a #1 2019-04-22 13:41:58 ~23 min android-e2e 📦 apk
✔️ db10e6a #1 2019-04-22 13:43:54 ~25 min windows 📦 exe
✔️ db10e6a #2 2019-04-22 14:03:21 ~23 min ios 📦 ipa
✔️ db10e6a #2 2019-04-24 17:06:05 ~14 min linux 📦 App
✔️ db10e6a #3 2019-04-25 10:28:39 ~25 min ios 📦 ipa
✔️ db10e6a #2 2019-04-25 11:12:05 ~19 min android 📦 apk
✔️ db10e6a #2 2019-05-02 09:50:38 ~21 min android-e2e 📦 apk
✔️ 36d178e #2 2019-05-02 12:24:59 ~14 min macos 📦 dmg
✔️ 36d178e #3 2019-05-02 12:26:57 ~16 min android 📦 apk
✔️ 36d178e #3 2019-05-02 12:29:41 ~19 min android-e2e 📦 apk
✔️ 36d178e #3 2019-05-02 12:32:36 ~22 min linux 📦 App
✔️ 36d178e #4 2019-05-02 12:33:40 ~23 min ios 📦 ipa
✔️ 36d178e #2 2019-05-02 12:38:58 ~28 min windows 📦 exe
✔️ 36d178e #4 2019-05-02 12:54:50 ~16 min android 📦 apk
✔️ 36d178e #5 2019-05-02 13:04:47 ~26 min ios 📦 ipa

@annadanchenko annadanchenko mentioned this pull request Apr 24, 2019
Closed
@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Passed tests: 46

Failed tests (2)

Click to expand
1. test_network_mismatch_for_send_request_commands

Device 2: Wait for CreateAccountButton
Device 1: Wait for OtherAccountsButton

Device 1: 'IHaveAccountButton' is not found on the screen

Device sessions

2. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_send_tokens_in_1_1_chat
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_swipe_to_delete_1_1_chat
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_request_eth_in_wallet
Device sessions

46. test_refresh_button_browsing_app_webview
Device sessions

@asemiankevich asemiankevich self-assigned this Apr 25, 2019
@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Passed tests: 46

Failed tests (2)

Click to expand
1. test_public_chat_messaging

Device 2: Looking for message with text 'hello'
Device 2: Looking for an element by text: 'Today'

Device 2: 'BaseButton' is not found on the screen

Device sessions

2. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_add_to_contacts
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_logcat_send_transaction_from_wallet
Device sessions

15. test_send_token_with_7_decimals
Device sessions

16. test_modify_transaction_fee_values
Device sessions

17. test_send_eth_from_wallet_to_address
Device sessions

18. test_manage_assets
Device sessions

19. test_logcat_send_transaction_in_1_1_chat
Device sessions

20. test_request_and_receive_eth_in_1_1_chat
Device sessions

21. test_swipe_to_delete_public_chat
Device sessions

22. test_send_emoji
Device sessions

23. test_search_chat_on_home
Device sessions

24. test_logcat_recovering_account
Device sessions

25. test_messaging_in_different_networks
Device sessions

26. test_send_tokens_in_1_1_chat
Device sessions

27. test_network_mismatch_for_send_request_commands
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_swipe_to_delete_1_1_chat
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_request_eth_in_wallet
Device sessions

46. test_refresh_button_browsing_app_webview
Device sessions

@asemiankevich
Copy link
Contributor

@jeluard user is still redirected to home, exactly as in issue described.

https://user-images.githubusercontent.com/8749671/55883419-fbe47000-5bae-11e9-960f-bdc1ba22b0df.gif

  1. open status
  2. open simpledapp.eth
  3. tap Status API
  4. tap Scan QR code
  5. scan any wallet code

i used this build https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190422-131847-db10e6-pr.apk on android 8. Could you please take a look?

@rachelhamlin
Copy link
Contributor

Can we let this one go from the release? It doesn't seem like a common use case to me. I don't know if I can think of any DApps with QR code scanners in them.

@asemiankevich
Copy link
Contributor

Can we let this one go from the release? It doesn't seem like a common use case to me. I don't know if I can think of any DApps with QR code scanners in them.

same happens when scanning extension code @rachelhamlin , could be critical to extensions developers. there is still a workaround (paste extensions url directly)

@jeluard
Copy link
Contributor Author

jeluard commented Apr 25, 2019

@asemiankevich extensions? Sounds like a different issue.
Now extensions are still alpha, behind a flag and not a prio for the next following months.

@asemiankevich
Copy link
Contributor

@asemiankevich extensions? Sounds like a different issue.
Now extensions are still alpha, behind a flag and not a prio for the next following months.

yes, similar issue with them #7995.
Lets then descope it from release , @annadanchenko please confirm

@jeluard
Copy link
Contributor Author

jeluard commented Apr 25, 2019

I would suggest that we merge this one still as a bug has been solved.
The other issue actually describes the behavior you see @asemiankevich

@churik
Copy link
Member

churik commented Apr 25, 2019 •
edited
Loading

@rachelhamlin issue #7948 is not only about DApps; it means also that you unable to scan valid bootnode / mailserver.
If it is OK for release - let's exclude it, but I don't think so.

@jeluard
Copy link
Contributor Author

jeluard commented Apr 25, 2019

@churik Both issues (API and the rest) are unrelated. Thus the reason to address the rest in the different issue.

@asemiankevich
Copy link
Contributor

@jeluard could you please explain what exactly is fixed here?

@jeluard
Copy link
Contributor Author

jeluard commented Apr 25, 2019

@asemiankevich Before the fix just opening the QR code scanner from simpleapp would make chat active (behind, look at the icon). Not anymore.
You can reproduce by opening the QR code and cancelling. It should stay in the DApp (previously moved to chat)

@rachelhamlin
Copy link
Contributor

Looking at #7995, which if separate, appears to be a bigger issue. Being able to scan a boot node/server is a concern.

However, it looks conditional upon having scanned an extension first? Continuing conversation there.

@Serhy
Copy link
Contributor

Serhy commented Apr 26, 2019

I can confirm #8014 (comment) that issue still present for Android and iOS

Android logcat logs starting from before QR code scanned:
LogcatRedirectToHomeFromDApp.log

Note: there is a same bug with redirect when scanning QR code, but three separate issues:
#7948 (When scan from DApp - current PR is intended to fix it)
#7995 - (When scan QR code from Profile -> Extentions)
#8044 - (When scan QR code from Mailserver and Bootnode)

The last one (#8044) - elected to be fixed in upcoming 0.12.0 release (but well, if is there is the same root cause and #8044 fix will close all of three above issues - that's even better for 0.12.0)

@oskarth oskarth requested a review from a team April 30, 2019 03:16
@yenda yenda mentioned this pull request May 1, 2019
Closed
@jeluard
Copy link
Contributor Author

jeluard commented May 2, 2019

@Serhy The issue I (and you?) described is still there in develop and fixed by this PR. Can you give it a try?

@status-github-bot
Copy link

status-github-bot bot commented May 2, 2019 •
edited by jeluard
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@jeluard
Copy link
Contributor Author

jeluard commented May 2, 2019

@asemiankevich Or maybe you are the one testing this PR?

@asemiankevich asemiankevich assigned Serhy and unassigned asemiankevich May 2, 2019
@Serhy
Copy link
Contributor

Serhy commented May 2, 2019

@jeluard I tested with Android 8.1 latest develop nightly build and this PR build (https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190425-105217-db10e6-pr.apk)
Navigation to Home screen when scan QR code in DApp still happens (#7948 still reproduced)

@Serhy
Copy link
Contributor

Serhy commented May 2, 2019

Hmm, @jeluard I checked Android and iOS builds from the closed @rasom's #8093 PR - and it's all fine there (along with QR scan from Mailserver/Extentions where we had a regression before)

@Serhy
Copy link
Contributor

Serhy commented May 2, 2019

Might be because this PR needs a rebase from Develop :)
Could you please rebase, @jeluard ?

@jeluard
Copy link
Contributor Author

jeluard commented May 2, 2019

So can you reproduce this issue on develop?

@Serhy
Copy link
Contributor

Serhy commented May 2, 2019

So can you reproduce this issue on develop?

Yes, I can reproduce the issue on develop.

@jeluard
Copy link
Contributor Author

jeluard commented May 2, 2019

@Serhy I just rebased

@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Passed tests: 46

Failed tests (2)

Click to expand
1. test_send_tokens_in_1_1_chat

Device 1: Wait for ChatMessageInput
Device 1: Wait for ChatMessageInput

Device 1: 'AddToContacts' is not found on the screen

Device sessions

2. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SendTransactionButton
Device 1: Wait for BackupRecoveryPhrase

'Backup your Recovery phrase' option is not shown on Wallet for an account with funds

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_network_mismatch_for_send_request_commands
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_swipe_to_delete_1_1_chat
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_request_eth_in_wallet
Device sessions

46. test_refresh_button_browsing_app_webview
Device sessions

@Serhy
Copy link
Contributor

Serhy commented May 2, 2019 •
edited
Loading

@jeluard Looks good to me!
Can scan QR code from within DApp with the latest iOS and Android build and stay on Dapp screen.
Scanning QR code when adding new user, extension, mailserver, bootnode, wallet QR code get the QR code value, pastes in the repsective field and stays on the same screen (no regression in this relation)

test_backup_recovery_phrase_warning_from_wallet - is known issue #8108
test_send_tokens_in_1_1_chat false fail (can't reproduce manually neither local test re-run pass)

@jeluard
[Fixed #7948] Do not navigate back to chat when in a DApp
25b17a8 
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
@jeluard jeluard merged commit 25b17a8 into develop May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the 7948 branch May 2, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda yenda approved these changes

@goranjovic goranjovic goranjovic approved these changes

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect to Chat screen when scan QR code within Dapp