Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] wallet on-error dispatch #8021

Merged
merged 1 commit into from
Apr 25, 2019
Merged

[fix] wallet on-error dispatch #8021

merged 1 commit into from
Apr 25, 2019

Conversation

yenda
Copy link
Contributor

@yenda yenda commented Apr 23, 2019 •
edited by 0xc1c4da
Loading

the code to dispatch an event on transaction error was not working
this fixes it

status: ready

@yenda yenda self-assigned this Apr 23, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Apr 23, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 4ff3318 #1 2019-04-23 12:44:28 ~8 min windows 📄 log
✔️ 4ff3318 #1 2019-04-23 12:49:07 ~13 min macos 📦 dmg
✔️ 4ff3318 #1 2019-04-23 12:52:02 ~16 min linux 📦 App
✔️ 4ff3318 #1 2019-04-23 12:52:43 ~16 min android 📦 apk
✔️ 4ff3318 #1 2019-04-23 12:58:25 ~22 min ios 📦 ipa
✔️ 4ff3318 #1 2019-04-23 12:59:05 ~23 min android-e2e 📦 apk
❌ 4ff3318 #2 2019-04-23 13:41:53 ~15 sec windows 📄 log
❌ 4ff3318 #3 2019-04-23 13:51:24 ~5 min windows 📄 log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6b6e47c #2 2019-04-25 05:49:19 ~15 min macos 📦 dmg
✔️ 6b6e47c #2 2019-04-25 05:52:27 ~18 min android-e2e 📦 apk
✔️ 6b6e47c #2 2019-04-25 05:53:06 ~19 min linux 📦 App
✔️ 6b6e47c #4 2019-04-25 05:54:15 ~20 min windows 📦 exe
✔️ 6b6e47c #2 2019-04-25 05:57:15 ~23 min ios 📦 ipa
❌ 3477d3a #3 2019-04-25 12:37:55 ~4 min ios 📄 log
✔️ 3477d3a #3 2019-04-25 12:47:42 ~14 min macos 📦 dmg
✔️ 3477d3a #4 2019-04-25 12:50:42 ~17 min android 📦 apk
✔️ 3477d3a #3 2019-04-25 12:52:35 ~19 min linux 📦 App
✔️ 3477d3a #5 2019-04-25 12:55:32 ~22 min windows 📦 exe
✔️ 3477d3a #3 2019-04-25 13:04:14 ~31 min android-e2e 📦 apk
❌ 3477d3a #4 2019-04-25 13:27:34 ~4 min ios 📄 log
✔️ 3477d3a #5 2019-04-25 14:44:47 ~26 min ios 📦 ipa

@annadanchenko
Copy link

@yenda

  1. Windows build failed
  2. To prevent side effects on release 0.12.0 can this PR be merged after we do code freeze (eod Wednesday) please? It's "skip qa" so we will not catch any side effects

@yenda
Copy link
Contributor Author

yenda commented Apr 23, 2019

@annadanchenko windows build failure is just so infra error I'll restart it, regarding merge we can wait but it won't matter it is fixing something that was just not working but isn't used in the current app anyway

@yenda yenda mentioned this pull request Apr 24, 2019
Closed
@yenda yenda force-pushed the fix/wallet-on-error-dispatch branch from 4ff3318 to 6b6e47c Compare April 25, 2019 05:33
@annadanchenko
Copy link

@yenda can you provide some details on how you've tested it, please? we might need to include such test into automated test suite - would be cool to get details for this

@yenda
Copy link
Contributor Author

yenda commented Apr 25, 2019

@annadanchenko this is not something that can be tested as there is no code using it yet, and such code would have not worked as there was a bug that this PR fixes which is why this is skip-qa labelled.

@yenda yenda force-pushed the fix/wallet-on-error-dispatch branch from 6b6e47c to 3477d3a Compare April 25, 2019 12:33
@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Passed tests: 47

Failed tests (1)

Click to expand
1. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (47)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_send_tokens_in_1_1_chat
Device sessions

28. test_network_mismatch_for_send_request_commands
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_swipe_to_delete_1_1_chat
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

[fix] wallet on-error dispatch
c4f7193 
the code to dispatch an event on transaction error was not working
this fixes it

Signed-off-by: yenda <eric@status.im>
@yenda yenda force-pushed the fix/wallet-on-error-dispatch branch from 3477d3a to c4f7193 Compare April 25, 2019 15:42
@yenda yenda merged commit c4f7193 into develop Apr 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/wallet-on-error-dispatch branch April 25, 2019 15:42
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2019
Closed
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@goranjovic goranjovic goranjovic approved these changes

@mandrigin mandrigin mandrigin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yenda @status-im-auto @annadanchenko @statustestbot @mandrigin @goranjovic @flexsurfer