fix token transactions

[yenda]

Fixes #7329 I would include this in release as not having token transactions shown at least for the last 14 days reliably is ridiculous

In #8005, token transactions were fetched more reliably but due to a bug, only inbound or outbound historical transactions would be fetched, and sometime some recent transactions would be skipped because the last block checked pointer was shared between inbound and outbound transaction

This fix makes sure that both inbound and outbound transactions are made from the same block, and removes an unecessary extra call to get-current-block

Testing

check that both inbound and outbound historical (last 14 days) transactions are shown, check that new token transactions are shown as well

status: ready

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	f7ed9e3	#1	2019-04-23 21:15:02	~4 min	ios	📄 log
✔️	f7ed9e3	#1	2019-04-23 21:23:31	~13 min	macos	📦 dmg
✔️	f7ed9e3	#1	2019-04-23 21:25:48	~15 min	linux	📦 App
✔️	f7ed9e3	#1	2019-04-23 21:28:07	~17 min	windows	📦 exe
✔️	f7ed9e3	#1	2019-04-23 21:28:09	~17 min	android	📦 apk
✔️	f7ed9e3	#2	2019-04-24 10:00:09	~18 min	android-e2e	📦 apk
✔️	f7ed9e3	#2	2019-04-24 10:05:03	~23 min	ios	📦 ipa
✔️	6022599	#3	2019-04-24 18:14:08	~20 min	android-e2e	📦 apk

[annadanchenko]

@yenda ios and android-e2e builds are failing

[statustestbot]

98% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Passed tests: 47

Failed tests (1)

Click to expand

1. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton Device 1: Wait for PlusButton Donation was not received during 300 seconds! Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (47)

Click to expand

1. test_block_user_from_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_filters_from_daap

Device sessions Device 1: Steps, video, logs

3. test_copy_and_paste_messages

Device sessions Device 1: Steps, video, logs

4. test_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

5. test_request_and_receive_tokens_in_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

6. test_deploy_contract_from_daap

Device sessions Device 1: Steps, video, logs

7. test_public_chat_messaging

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

8. test_password_in_logcat_sign_in

Device sessions Device 1: Steps, video, logs

9. test_text_message_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

10. test_add_to_contacts

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

11. test_sign_typed_message (TestRail link is not found)

Device sessions Device 1: Steps, video, logs

12. test_unread_messages_counter_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

13. test_logcat_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

14. test_send_message_in_group_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_logcat_send_transaction_from_wallet

Device sessions Device 1: Steps, video, logs

16. test_send_token_with_7_decimals

Device sessions Device 1: Steps, video, logs

17. test_modify_transaction_fee_values

Device sessions Device 1: Steps, video, logs

18. test_send_eth_from_wallet_to_address

Device sessions Device 1: Steps, video, logs

19. test_manage_assets

Device sessions Device 1: Steps, video, logs

20. test_logcat_send_transaction_in_1_1_chat

Device sessions Device 1: Steps, video, logs

21. test_request_and_receive_eth_in_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

22. test_swipe_to_delete_public_chat

Device sessions Device 1: Steps, video, logs

23. test_send_emoji

Device sessions Device 1: Steps, video, logs

24. test_search_chat_on_home

Device sessions Device 1: Steps, video, logs

25. test_logcat_recovering_account

Device sessions Device 1: Steps, video, logs

26. test_messaging_in_different_networks

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

27. test_send_tokens_in_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

28. test_network_mismatch_for_send_request_commands

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

29. test_logcat_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

30. test_swipe_to_delete_1_1_chat

Device sessions Device 1: Steps, video, logs

31. test_switch_users_and_add_new_account

Device sessions Device 1: Steps, video, logs

32. test_send_stt_from_wallet

Device sessions Device 1: Steps, video, logs

33. test_send_eth_in_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

34. test_login_with_new_account

Device sessions Device 1: Steps, video, logs

35. test_send_eth_from_wallet_to_contact

Device sessions Device 1: Steps, video, logs

36. test_add_contact_from_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

37. test_send_two_transactions_one_after_another_in_dapp

Device sessions Device 1: Steps, video, logs

38. test_password_in_logcat_creating_account

Device sessions Device 1: Steps, video, logs

39. test_backup_recovery_phrase

Device sessions Device 1: Steps, video, logs

40. test_offline_status

Device sessions Device 1: Steps, video, logs

41. test_open_google_com_via_open_dapp

Device sessions Device 1: Steps, video, logs

42. test_unread_messages_counter_public_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

43. test_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

44. test_user_can_remove_profile_picture

Device sessions Device 1: Steps, video, logs

45. test_share_contact_code_and_wallet_address

Device sessions Device 1: Steps, video, logs

46. test_request_eth_in_wallet

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

47. test_refresh_button_browsing_app_webview

Device sessions Device 1: Steps, video, logs

[churik]

@yenda thank you!
It works.
Checked (on Mainnet and Ropsten):

• restore the wallet with token and ETH transactions (all token transactions during last 14 days are shown normally and match Etherscan)
• send several transactions in tokens \ ETH and check incoming and outgoing. Check that transaction are shown normally after relogin.
• failed tests was checked manually - it works.
  Failed due to infrastracture error.

[status-github-bot]

Pull Request Checklist

• Have you updated the documentation, if impacted (e.g. docs.status.im)?