[7105] Feature - Adding error for a field defined with range #8229

alexanmtz · 2019-05-17T20:45:03Z

Fixes #7105

Summary

Support input range validation with min and max properties

Review notes

Add the extension code, install it and check the validation

Testing notes

Add the extension code, install it and check the validation

Platforms

Android
iOS
macOS
Linux
Windows

Areas that maybe impacted

Extensions

Functional

1-1 chats
public chats
group chats
wallet / transactions
dapps / app browsing
account recovery
new account
user profile updates
networks
mailservers
fleet
bootnodes

Non-functional

battery performance
CPU performance / speed of the app
network consumption

Steps to test

Add the following extension to test

{meta {:name "Test extension example 10"
:description "just to test the input error example version 10"
:documentation ""}

views/hello
[input {:style {:margin 10} :placeholder "Test" :min 1 :max 8}]

hooks/wallet.settings.hello
{:label "Settings for test error input extension"
:view [hello]}}

Open Status
...
Step 3, etc.

status: ready

status-github-bot · 2019-05-17T20:45:09Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-05-17T21:02:19Z

Jenkins Builds

Click to see older builds (27)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d3104dc`	#1	2019-05-17 21:02:18	~17 min	`android`	📦 apk
✔️	`d3104dc`	#1	2019-05-17 21:04:43	~19 min	`android-e2e`	📦 apk
✔️	`d3104dc`	#1	2019-05-17 21:05:54	~20 min	`macos`	📦 dmg
✔️	`d3104dc`	#1	2019-05-17 21:08:36	~23 min	`linux`	📦 App
✔️	`d3104dc`	#1	2019-05-17 21:09:37	~24 min	`windows`	📦 exe
✔️	`d3104dc`	#1	2019-05-17 21:09:44	~24 min	`ios`	📦 ipa

✔️	`b1ef307`	#2	2019-05-17 22:24:16	~17 min	`android-e2e`	📦 apk
✔️	`b1ef307`	#2	2019-05-17 22:24:20	~17 min	`android`	📦 apk
✔️	`b1ef307`	#2	2019-05-17 22:26:55	~19 min	`macos`	📦 dmg
✔️	`b1ef307`	#2	2019-05-17 22:30:41	~23 min	`ios`	📦 ipa
✔️	`b1ef307`	#2	2019-05-17 22:32:42	~25 min	`windows`	📦 exe

✔️	`156f342`	#3	2019-05-22 21:32:17	~17 min	`macos`	📦 dmg
✔️	`156f342`	#3	2019-05-22 21:32:59	~18 min	`android`	📦 apk
✔️	`156f342`	#3	2019-05-22 21:34:24	~19 min	`android-e2e`	📦 apk
✔️	`156f342`	#3	2019-05-22 21:36:22	~21 min	`linux`	📦 App
✔️	`156f342`	#3	2019-05-22 21:36:55	~21 min	`windows`	📦 exe
✔️	`156f342`	#3	2019-05-22 21:41:03	~26 min	`ios`	📦 ipa

❌	`ea81090`	#6	2019-06-04 16:23:58	~2 min	`ios`	📄 log
❌	`ea81090`	#6	2019-06-04 16:24:02	~2 min	`linux`	📄 log
❌	`ea81090`	#6	2019-06-04 16:24:20	~3 min	`windows`	📄 log
❌	`ea81090`	#6	2019-06-04 16:24:32	~3 min	`macos`	📄 log
❌	`ea81090`	#6	2019-06-04 16:31:00	~10 min	`android-e2e`	📄 log
❌	`ea81090`	#6	2019-06-04 16:31:00	~10 min	`android`	📄 log

❌	`898db7c`	#7	2019-06-07 08:40:13	~2 min	`ios`	📄 log
❌	`898db7c`	#7	2019-06-07 08:40:34	~2 min	`windows`	📄 log
❌	`898db7c`	#7	2019-06-07 08:40:44	~2 min	`macos`	📄 log
❌	`898db7c`	#7	2019-06-07 08:40:44	~2 min	`linux`	📄 log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`9e7d80a`	#8	2019-06-07 08:44:51	~1 min	`linux`	📄 log
❌	`9e7d80a`	#8	2019-06-07 08:45:15	~2 min	`macos`	📄 log
❌	`9e7d80a`	#8	2019-06-07 08:45:45	~2 min	`windows`	📄 log
❌	`9e7d80a`	#8	2019-06-07 08:47:46	~4 min	`ios`	📄 log
❌	`9e7d80a`	#8	2019-06-07 08:47:59	~5 min	`android`	📄 log
❌	`9e7d80a`	#8	2019-06-07 08:48:10	~5 min	`android-e2e`	📄 log

✔️	`e98a964`	#11	2019-06-11 15:49:05	~12 min	`android`	📦 apk
✔️	`e98a964`	#10	2019-06-11 15:49:08	~12 min	`android-e2e`	📦 apk
✔️	`e98a964`	#10	2019-06-11 15:49:21	~12 min	`ios`	📦 ipa
✔️	`e98a964`	#10	2019-06-11 15:52:52	~15 min	`macos`	📦 dmg
✔️	`e98a964`	#10	2019-06-11 15:54:34	~17 min	`linux`	📦 App
✔️	`e98a964`	#10	2019-06-11 15:55:52	~18 min	`windows`	📦 exe

jeluard · 2019-05-21T09:51:13Z

src/status_im/extensions/capacities/components.cljs

-(defn input [{:keys [keyboard-type style error on-change change-delay placeholder placeholder-text-color selection-color
+(defn- in-range
+  ;; Determines whether a number is in a range
+  [n, start, end]


Commas are a bit weird here :)

No more commas at all 👍

I still see them?

@jeluard it was removed in the last commit: 0ce6e99

they are still here

commas still here

jeluard · 2019-05-21T09:51:35Z

src/status_im/extensions/capacities/components.cljs

@@ -25,26 +28,44 @@
    (js/clearTimeout id))
  (reset! current (js/setTimeout #(on-input-change-text on-change value) delay)))

-(defn input [{:keys [keyboard-type style error on-change change-delay placeholder placeholder-text-color selection-color
+(defn- in-range
+  ;; Determines whether a number is in a range


Should be defined as function doc?

I think no need comments at all, the function is pretty simple and self explained

jeluard · 2019-05-21T09:52:17Z

src/status_im/extensions/capacities/components.cljs

+  (cond
+    (nil? n) true
+    (and (nil? start) (nil? end)) true
+    (= n "") true


Can be combined with nil check into string/empty?

changed 👍

it could be simplest form
(or (string/blank? n) (and (nil? start) (nil? end)) (and (< n end) (> n start)) )

jeluard · 2019-05-21T09:52:40Z

src/status_im/extensions/capacities/components.cljs

-     [tooltip/tooltip error (styles/error error)])])
+
+  (let [input-range (reagent/atom nil)]
+    (fn []


Why the fn here?

@jeluard I tried to do in different ways, and only works when there's a anonymous function to handle. In some tutorials about atoms and event handling using clojure, reagent and react it was using this approach.

What didn't work w/o it?

@jeluard I think it is related to event handling with reagent, it needs to re-render once the atom change with the updated values.

You can see here:
https://github.com/status-im/status-react/blob/develop/src/status_im/ui/screens/wallet/components/views.cljs#L229

It is a similar situation where fn is used, I there's many of those inside the project.

But what didn't work exactly? Not clear from your comments

Sorry @jeluard, without fn wrapped on the component when using reagent/atom, the input don't update the atom value and didn't check on on-change for the in-range function, so nothing happens if I get rid of the fn inside. This means the validation and the input error don't appear and nothing happens.

jeluard · 2019-05-21T09:53:11Z

src/status_im/extensions/capacities/components.cljs

-            [status-im.ui.components.text-input.styles :as styles]
-            [status-im.extensions.capacities.map :as map-component]))
+  (:require
+   [reagent.core :as reagent]


We usually use previous format

I don't know why these spaces was inserted, but I Solved now 👍

flexsurfer

for some reason i can't see changes in the code, maybe something wrong with commits. could you please squash commits and rebase onto develop, thanks

flexsurfer · 2019-06-04T06:23:51Z

src/status_im/extensions/capacities/components.cljs

-(defn input [{:keys [keyboard-type style error on-change change-delay placeholder placeholder-text-color selection-color
+(defn- in-range
+  ;; Determines whether a number is in a range
+  [n, start, end]


they are still here

flexsurfer · 2019-06-04T06:25:32Z

src/status_im/extensions/capacities/components.cljs

+  (cond
+    (nil? n) true
+    (and (nil? start) (nil? end)) true
+    (= n "") true


it could be simplest form
(or (string/blank? n) (and (nil? start) (nil? end)) (and (< n end) (> n start)) )

alexanmtz · 2019-06-04T16:34:44Z

please try now @flexsurfer , there's a only commit only now 👍

src/status_im/extensions/capacities/components.cljs

Serhy · 2019-06-11T12:15:47Z

Hey @alexanmtz could you please rebase onto develop (because builds are failing to succeed) and squash your commits into one?

alexanmtz · 2019-06-11T15:38:20Z

Done 👍 @Serhy

asemiankevich · 2019-06-12T07:05:10Z

@alexanmtz do you have your extension posted on ipfs so you can share a link?

statustestbot · 2019-06-12T07:11:58Z

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand

1. test_backup_recovery_phrase_warning_from_wallet
Device 1: Wait for PlusButton Device 1: Wait for PlusButton `Donation was not received during 300 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (48)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_request_and_receive_tokens_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
7. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
8. test_public_chat_messaging
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
9. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
10. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
11. test_text_message_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_sign_typed_message (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
14. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
15. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
16. test_send_message_in_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
18. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
19. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
20. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
21. test_manage_assets
Device sessions Device 1: Steps, video, logs
22. test_logcat_send_transaction_in_1_1_chat
Device sessions Device 1: Steps, video, logs
23. test_request_and_receive_eth_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
24. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
25. test_send_emoji
Device sessions Device 1: Steps, video, logs
26. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
27. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
28. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_send_tokens_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
30. test_network_mismatch_for_send_request_commands
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
32. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
33. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
34. test_send_eth_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
36. test_send_eth_from_wallet_to_contact
Device sessions Device 1: Steps, video, logs
37. test_add_contact_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
38. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
39. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
40. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
41. test_offline_status
Device sessions Device 1: Steps, video, logs
42. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
43. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
44. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
45. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
46. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
47. test_request_eth_in_wallet
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
48. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs

alexanmtz · 2019-06-12T07:44:14Z

@alexanmtz do you have your extension posted on ipfs so you can share a link?

@asemiankevich https://get.status.im/extension/ipfs@QmShrYmDYGAicPRYkqfq98Aipee5oQ1op5r9ZCwGjJWF7g/

Is set to a min value of 1 and max of 8 to the input test, that would be available on wallet settings.

alexanmtz · 2019-06-12T07:44:49Z

The code of the extension is on the PR:

{meta {:name "Test extension example 10"
:description "just to test the input error example version 10"
:documentation ""}

views/hello
[input {:style {:margin 10} :placeholder "Test" :min 1 :max 8}]

hooks/wallet.settings.hello
{:label "Settings for test error input extension"
:view [hello]}}

asemiankevich · 2019-06-12T07:48:20Z

@alexanmtz do you have your extension posted on ipfs so you can share a link?

@asemiankevich https://get.status.im/extension/ipfs@QmShrYmDYGAicPRYkqfq98Aipee5oQ1op5r9ZCwGjJWF7g/

Is set to a min value of 1 and max of 8 to the input test, that would be available on wallet settings.

it fails after i install it in status

alexanmtz · 2019-06-12T07:53:50Z

@alexanmtz do you have your extension posted on ipfs so you can share a link?

@asemiankevich https://get.status.im/extension/ipfs@QmShrYmDYGAicPRYkqfq98Aipee5oQ1op5r9ZCwGjJWF7g/
Is set to a min value of 1 and max of 8 to the input test, that would be available on wallet settings.

it fails after i install it in status

Try this:
https://get.status.im/extension/ipfs@QmaRbdPJjzLiRGGb68Vx2DpPb8simpHBFBTQG1gcbjrFpq/

Or try to create the extension yourself with the code I provided.

Serhy · 2019-06-12T14:51:24Z

Looks good on iOS and Android.
Scientific format also supported (which I take as expected) - i.e. 1e1 returns true in a -100..100 range.

-1 ... 100 range handling values fine (extension: https://get.status.im/extension/ipfs@QmYAjQ1Kq9bknVWs9YZLKsBqRquTEzZd82CTMfWWiKDLmr )
0.00000001 …. 100000000000000000 range handle values fine (extension https://get.status.im/extension/ipfs@QmRFBrC2XfjrJqGrDHtb5rvct2gtGh7zKBBBnnpWiZE3QV )

Thanks, @alexanmtz !

…xtensions Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

alexanmtz requested a review from a team as a code owner May 17, 2019 20:45

alexanmtz changed the title ~~Issue 7105 - Adding error for a field defined with range~~ [7105] Feature - Adding error for a field defined with range May 17, 2019

flexsurfer added bounty community labels May 20, 2019

flexsurfer requested a review from jeluard May 20, 2019 07:19

jeluard suggested changes May 21, 2019

View reviewed changes

alexanmtz mentioned this pull request May 27, 2019

Update extension input to support number range #7105

Closed

weekly-digest bot mentioned this pull request Jun 2, 2019

Weekly Digest (26 May, 2019 - 2 June, 2019) #8335

Closed

jeluard requested a review from flexsurfer June 3, 2019 17:52

jeluard approved these changes Jun 3, 2019

View reviewed changes

flexsurfer requested changes Jun 4, 2019

View reviewed changes

alexanmtz force-pushed the feature/7105-update-extension-to-support-number-range branch 3 times, most recently from f622566 to ea81090 Compare June 4, 2019 16:20

flexsurfer reviewed Jun 7, 2019

View reviewed changes

src/status_im/extensions/capacities/components.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed Jun 7, 2019

View reviewed changes

src/status_im/extensions/capacities/components.cljs Show resolved Hide resolved

flexsurfer reviewed Jun 7, 2019

View reviewed changes

src/status_im/extensions/capacities/components.cljs Outdated Show resolved Hide resolved

flexsurfer approved these changes Jun 8, 2019

View reviewed changes

weekly-digest bot mentioned this pull request Jun 9, 2019

Weekly Digest (2 June, 2019 - 9 June, 2019) #8389

Closed

alexanmtz force-pushed the feature/7105-update-extension-to-support-number-range branch from c6e92f9 to e98a964 Compare June 11, 2019 15:36

asemiankevich self-assigned this Jun 12, 2019

Serhy self-assigned this Jun 12, 2019

Serhy added the Tested - OK label Jun 12, 2019

adding error for a field defined with range that is out of range on e…

287e097

…xtensions Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

flexsurfer force-pushed the feature/7105-update-extension-to-support-number-range branch from e98a964 to 287e097 Compare June 12, 2019 15:02

flexsurfer merged commit 287e097 into status-im:develop Jun 12, 2019

weekly-digest bot mentioned this pull request Jun 16, 2019

Weekly Digest (9 June, 2019 - 16 June, 2019) #8423

Closed

StatusWrike unassigned asemiankevich Sep 12, 2019

StatusWrike unassigned Serhy Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7105] Feature - Adding error for a field defined with range #8229

[7105] Feature - Adding error for a field defined with range #8229

alexanmtz commented May 17, 2019 •

edited by StatusWrike

Loading

status-github-bot bot commented May 17, 2019

status-im-auto commented May 17, 2019 •

edited

Loading

jeluard May 21, 2019

alexanmtz May 22, 2019

jeluard May 27, 2019

alexanmtz May 31, 2019

flexsurfer Jun 4, 2019

flexsurfer Jun 7, 2019

jeluard May 21, 2019

alexanmtz May 22, 2019

jeluard May 21, 2019

alexanmtz May 22, 2019

flexsurfer Jun 4, 2019

jeluard May 21, 2019

alexanmtz May 22, 2019

jeluard May 27, 2019

alexanmtz May 31, 2019

jeluard Jun 3, 2019

alexanmtz Jun 3, 2019

jeluard May 21, 2019

alexanmtz May 22, 2019

flexsurfer left a comment

flexsurfer Jun 4, 2019

flexsurfer Jun 4, 2019

alexanmtz commented Jun 4, 2019

Serhy commented Jun 11, 2019

alexanmtz commented Jun 11, 2019

asemiankevich commented Jun 12, 2019

statustestbot commented Jun 12, 2019

alexanmtz commented Jun 12, 2019 •

edited

Loading

alexanmtz commented Jun 12, 2019

asemiankevich commented Jun 12, 2019

alexanmtz commented Jun 12, 2019 •

edited

Loading

Serhy commented Jun 12, 2019

[7105] Feature - Adding error for a field defined with range #8229

[7105] Feature - Adding error for a field defined with range #8229

Conversation

alexanmtz commented May 17, 2019 • edited by StatusWrike Loading

Summary

Review notes

Testing notes

Platforms

Areas that maybe impacted

Functional

Non-functional

Steps to test

status-github-bot bot commented May 17, 2019

Pull Request Checklist

status-im-auto commented May 17, 2019 • edited Loading

Jenkins Builds

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flexsurfer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexanmtz commented Jun 4, 2019

Serhy commented Jun 11, 2019

alexanmtz commented Jun 11, 2019

asemiankevich commented Jun 12, 2019

statustestbot commented Jun 12, 2019

98% of end-end tests have passed

Failed tests (1)

Passed tests (48)

alexanmtz commented Jun 12, 2019 • edited Loading

alexanmtz commented Jun 12, 2019

asemiankevich commented Jun 12, 2019

alexanmtz commented Jun 12, 2019 • edited Loading

Serhy commented Jun 12, 2019

alexanmtz commented May 17, 2019 •

edited by StatusWrike

Loading

status-im-auto commented May 17, 2019 •

edited

Loading

alexanmtz commented Jun 12, 2019 •

edited

Loading

alexanmtz commented Jun 12, 2019 •

edited

Loading