Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] Minimize com.taoensso/timbre dependencies #8390

Merged
merged 1 commit into from
Jun 10, 2019
Merged

[perf] Minimize com.taoensso/timbre dependencies #8390

merged 1 commit into from
Jun 10, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jun 9, 2019 •
edited by StatusWrike
Loading

taoensso/timbre#278

saves more than 100KB when compiled with :advanced. It seems that this code is quite heavy so it costs ~450ms of startup time on my slow device (galaxy a500d).

status: ready

@rasom rasom requested a review from a team as a code owner June 9, 2019 04:57
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jun 9, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cdae342 #1 2019-06-09 05:11:12 ~13 min linux 📦 App
✔️ cdae342 #1 2019-06-09 05:11:45 ~14 min ios 📦 ipa
✔️ cdae342 #1 2019-06-09 05:13:41 ~16 min windows 📦 exe
✔️ cdae342 #1 2019-06-09 05:13:51 ~16 min android 📦 apk
✔️ cdae342 #1 2019-06-09 05:14:07 ~16 min android-e2e 📦 apk
✔️ cdae342 #1 2019-06-09 05:14:14 ~16 min macos 📦 dmg

@rasom rasom self-assigned this Jun 9, 2019
@statustestbot
Copy link

73% of end-end tests have passed

Total executed tests: 49
Failed tests: 13
Passed tests: 36

Failed tests (13)

Click to expand
1. test_block_user_from_public_chat

Device 1: Tap on SignInButton
Device 1: Tap on PlusButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

2. test_send_transaction_from_daap

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Balance is not changed during 360 seconds, funds were not received!

Device sessions

3. test_request_and_receive_tokens_in_1_1_chat

Device 2: Looking for a message by text: '0.00915521'
Device 2: Wait for ChatElementByText

Transaction with amount 0.00915521 is not found in list of transactions, address is e71c43413559e40ebcb602fb95c33662926cc000

Device sessions

4. test_logcat_send_transaction_from_wallet

Device 1: Tap on PassphraseInput
Device 1: Type 'ahead warrior poet radio image topic wasp clever banner angry age quality' to PassphraseInput

Device 1: 'PasswordInput' is not found on the screen

Device sessions

5. test_send_token_with_7_decimals

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Transaction with amount 0.0899211 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

6. test_modify_transaction_fee_values

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Transaction with amount 0.009161348 is not found in list of transactions, address is b92496fffd668c2de08694623303456aa98cdf33

Device sessions

7. test_send_eth_from_wallet_to_address

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Transaction with amount 0.009161343 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913

Device sessions

8. test_request_and_receive_eth_in_1_1_chat

Device 2: Waiting 300 seconds for ETH update
Device 2: Balance is not changed during 300 seconds!

Transaction with amount 0.00915529 is not found in list of transactions, address is 1fc705a336a0a2e48eb3c953ce577e591f2767ad

Device sessions

9. test_send_tokens_in_1_1_chat

Device 2: Looking for a message by text: '0.00915517'
Device 2: Wait for ChatElementByText

Transaction with amount 0.00915517 is not found in list of transactions, address is 702995aa7dc6aad543661aab35494f4986022659

Device sessions

10. test_send_stt_from_wallet

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Transaction with amount 0.009161425 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

11. test_send_eth_in_1_1_chat

Device 2: Waiting 300 seconds for ETH update
Device 2: Balance is not changed during 300 seconds!

Transaction with amount 0.00915494 is not found in list of transactions, address is d630b1224683a438582e3e14e35ba5e03513eaab

Device sessions

12. test_send_eth_from_wallet_to_contact

Device 1: Wait for GotItButton
Device 1: Tap on GotItButton

Transaction with amount 0.00916144 is not found in list of transactions, address is d117188dbf1c160074cc4850a1d140286fdfc831

Device sessions

13. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (36)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_deploy_contract_from_daap
Device sessions

4. test_open_transaction_on_etherscan
Device sessions

5. test_public_chat_messaging
Device sessions

6. test_long_press_to_delete_1_1_chat
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_add_to_contacts
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_manage_assets
Device sessions

15. test_logcat_send_transaction_in_1_1_chat
Device sessions

16. test_long_press_to_delete_public_chat
Device sessions

17. test_send_emoji
Device sessions

18. test_search_chat_on_home
Device sessions

19. test_logcat_recovering_account
Device sessions

20. test_messaging_in_different_networks
Device sessions

21. test_network_mismatch_for_send_request_commands
Device sessions

22. test_logcat_sign_message_from_daap
Device sessions

23. test_switch_users_and_add_new_account
Device sessions

24. test_login_with_new_account
Device sessions

25. test_add_contact_from_public_chat
Device sessions

26. test_send_two_transactions_one_after_another_in_dapp
Device sessions

27. test_password_in_logcat_creating_account
Device sessions

28. test_backup_recovery_phrase
Device sessions

29. test_offline_status
Device sessions

30. test_open_google_com_via_open_dapp
Device sessions

31. test_unread_messages_counter_public_chat
Device sessions

32. test_sign_message_from_daap
Device sessions

33. test_user_can_remove_profile_picture
Device sessions

34. test_share_contact_code_and_wallet_address
Device sessions

35. test_request_eth_in_wallet
Device sessions

36. test_refresh_button_browsing_app_webview
Device sessions

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand
1. test_public_chat_messaging

Device 2: Looking for message with text 'hello'
Device 2: Looking for an element by text: 'Today'

Device 2: 'BaseButton' is not found on the screen

Device sessions

Passed tests (48)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_long_press_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

48. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot
Copy link

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Passed tests: 0

Failed tests (1)

Click to expand
1. test_public_chat_messaging

Device 2: Looking for message with text 'hello'
Device 2: Looking for an element by text: 'Today'

Device 2: 'BaseButton' is not found on the screen

Device sessions

@asemiankevich
Copy link
Contributor

last failed test is known issue #7090

@rasom
Copy link
Contributor Author

rasom commented Jun 10, 2019

@asemiankevich ok thanks

@rasom rasom merged commit cdae342 into develop Jun 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-taoensso-encore branch June 10, 2019 07:24
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda yenda approved these changes

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@cammellos cammellos Awaiting requested review from cammellos

@mandrigin mandrigin Awaiting requested review from mandrigin

Assignees
No one assigned
Labels
performance
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rasom @status-im-auto @statustestbot @asemiankevich @pedropombeiro @yenda @flexsurfer