Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] prod version of slurp #8394

Merged
merged 1 commit into from
Jun 11, 2019
Merged

[perf] prod version of slurp #8394

merged 1 commit into from
Jun 11, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jun 10, 2019

solves #8381
solves #8383

review only the last commit

All resources loaded by slurp are moved to status-modules/resources dir
in release builds and are loaded only by demand instead of being bundled into
index.*.js.

status: ready

@rasom rasom requested review from antdanchenko, churik and a team as code owners June 10, 2019 06:34
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom self-assigned this Jun 10, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 10, 2019

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 54ca1ca #1 2019-06-10 06:48:20 ~13 min ios 📦 ipa
✔️ 54ca1ca #1 2019-06-10 06:50:09 ~15 min android 📦 apk
✔️ 54ca1ca #1 2019-06-10 06:50:21 ~15 min android-e2e 📦 apk
✔️ 54ca1ca #1 2019-06-10 06:50:30 ~15 min linux 📦 App
✔️ 54ca1ca #1 2019-06-10 06:50:52 ~16 min macos 📦 dmg
✔️ 54ca1ca #1 2019-06-10 06:53:04 ~18 min windows 📦 exe
✔️ ea2a7ec #2 2019-06-10 07:48:12 ~13 min linux 📦 App
✔️ ea2a7ec #2 2019-06-10 07:48:54 ~14 min ios 📦 ipa
✔️ ea2a7ec #2 2019-06-10 07:51:19 ~16 min windows 📦 exe
✔️ ea2a7ec #2 2019-06-10 07:52:45 ~18 min macos 📦 dmg
✔️ ea2a7ec #2 2019-06-10 07:56:21 ~21 min android 📦 apk
✔️ ea2a7ec #2 2019-06-10 07:56:34 ~21 min android-e2e 📦 apk
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 198b6ec #3 2019-06-10 18:39:24 ~23 min ios 📦 ipa
✔️ 198b6ec #3 2019-06-10 18:42:09 ~26 min macos 📦 dmg
✔️ 198b6ec #3 2019-06-10 18:42:51 ~26 min android 📦 apk
✔️ 198b6ec #3 2019-06-10 18:43:02 ~27 min android-e2e 📦 apk
✔️ 198b6ec #3 2019-06-10 18:43:29 ~27 min linux 📦 App
✔️ 198b6ec #3 2019-06-10 18:46:20 ~30 min windows 📦 exe
✔️ e925b2d #4 2019-06-11 13:05:44 ~12 min android 📦 apk
✔️ e925b2d #4 2019-06-11 13:05:44 ~12 min linux 📦 App
✔️ e925b2d #4 2019-06-11 13:06:03 ~13 min ios 📦 ipa
✔️ e925b2d #4 2019-06-11 13:06:34 ~13 min android-e2e 📦 apk
✔️ e925b2d #4 2019-06-11 13:06:46 ~13 min windows 📦 exe
✔️ e925b2d #4 2019-06-11 13:07:03 ~14 min macos 📦 dmg

src/status_im/ui/screens/browser/views.cljs Outdated Show resolved Hide resolved
@Serhy
Copy link
Contributor

Serhy commented Jun 11, 2019

No regressions in DApp and browsing on iOS and Android (8th, 6.0.1 tested).
Also, can install and use extensions fine (gfycat, wallet 'hello world' extension), can revoke access to Dapp from Profile

All resources loaded by slurp are moved to status-modules/resources dir
in release builds and are loaded only by demand instead of being bundled into
index.*.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants