Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobile] switch to png icons #8400

Merged
merged 1 commit into from
Jun 18, 2019
Merged

[mobile] switch to png icons #8400

merged 1 commit into from
Jun 18, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jun 11, 2019

status: ready

@rasom rasom requested a review from a team as a code owner June 11, 2019 08:43
@auto-assign auto-assign bot removed the request for review from a team June 11, 2019 08:43
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom self-assigned this Jun 11, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 11, 2019

Jenkins Builds

Click to see older builds (25)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 276bd79 #1 2019-06-11 08:58:22 ~14 min windows 📦 exe
✔️ 276bd79 #1 2019-06-11 08:58:25 ~14 min android-e2e 📦 apk
✔️ 276bd79 #1 2019-06-11 08:58:43 ~14 min ios 📦 ipa
✔️ 276bd79 #1 2019-06-11 09:00:15 ~16 min android 📦 apk
✔️ 276bd79 #1 2019-06-11 09:02:03 ~18 min linux 📦 App
✔️ 276bd79 #1 2019-06-11 09:02:08 ~18 min macos 📦 dmg
✔️ d1e3da0 #2 2019-06-11 14:30:33 ~13 min ios 📦 ipa
✔️ d1e3da0 #2 2019-06-11 14:31:07 ~14 min windows 📦 exe
✔️ d1e3da0 #2 2019-06-11 14:32:14 ~15 min android-e2e 📦 apk
✔️ d1e3da0 #2 2019-06-11 14:33:35 ~16 min android 📦 apk
✔️ d1e3da0 #2 2019-06-11 14:34:28 ~17 min macos 📦 dmg
✔️ d1e3da0 #2 2019-06-11 14:35:51 ~18 min linux 📦 App
4214d96 #3 2019-06-12 19:18:50 ~13 min android-e2e 📄 log
✔️ 4214d96 #3 2019-06-12 19:18:52 ~13 min windows 📦 exe
✔️ 4214d96 #3 2019-06-12 19:19:47 ~14 min ios 📦 ipa
✔️ 4214d96 #3 2019-06-12 19:20:52 ~15 min android 📦 apk
✔️ 4214d96 #3 2019-06-12 19:22:23 ~17 min macos 📦 dmg
✔️ 4214d96 #3 2019-06-12 19:22:53 ~17 min linux 📦 App
✔️ 4214d96 #4 2019-06-13 13:56:15 ~14 min android-e2e 📦 apk
e8e47c9 #5 2019-06-17 05:21:45 ~11 min android-e2e 📄 log
✔️ e8e47c9 #4 2019-06-17 05:22:09 ~12 min windows 📦 exe
✔️ e8e47c9 #4 2019-06-17 05:23:08 ~13 min ios 📦 ipa
✔️ e8e47c9 #4 2019-06-17 05:23:22 ~13 min macos 📦 dmg
✔️ e8e47c9 #4 2019-06-17 05:24:39 ~14 min android 📦 apk
✔️ e8e47c9 #4 2019-06-17 05:25:40 ~15 min linux 📦 App
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dab8be2 #5 2019-06-17 13:43:40 ~13 min android 📦 apk
✔️ dab8be2 #6 2019-06-17 13:43:40 ~13 min android-e2e 📦 apk
✔️ dab8be2 #5 2019-06-17 13:44:04 ~13 min ios 📦 ipa
✔️ dab8be2 #5 2019-06-17 13:44:48 ~14 min linux 📦 App
✔️ dab8be2 #5 2019-06-17 13:46:06 ~15 min macos 📦 dmg
✔️ dab8be2 #5 2019-06-17 13:47:11 ~16 min windows 📦 exe
✔️ 6da2c93 #6 2019-06-18 12:22:50 ~12 min linux 📦 App
✔️ 6da2c93 #6 2019-06-18 12:23:33 ~12 min ios 📦 ipa
✔️ 6da2c93 #6 2019-06-18 12:23:35 ~12 min windows 📦 exe
✔️ 6da2c93 #6 2019-06-18 12:24:43 ~13 min macos 📦 dmg
✔️ 6da2c93 #6 2019-06-18 12:26:56 ~16 min android 📦 apk
✔️ 6da2c93 #7 2019-06-18 12:27:10 ~16 min android-e2e 📦 apk

Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about removing svgs ?

(update icon-vec 1 assoc :width width :height height)
icon-vec))
(throw (js/Error. (str "Unknown icon: " name))))])
[react/view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting why was it animated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

@flexsurfer they are used on desktop; right now I'm trying to verify if there is actually any improvement

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand
1. test_block_user_from_public_chat

Device 1: Tap on SignInButton
Device 1: Tap on PlusButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

Passed tests (48)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_long_press_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

48. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

Teststed on slow device:

  1. "Add chat" animation
    I measured time between clicking "add" button, start of animation and end of animation. The first frame is the one where there is no touch icon on "add" button. 30fps, samsung a500d
pr release build develop release build
1. 11(1) 14(9) this one was really bad
2. 11(1) 11(4)
3. 11(1) 12(5)
avg 11(1) 12.3(6)

So with png the animation starts much earlier, with svg it is delayed for at least 3 frames (6 at 60fps), which is 100ms.

  1. Wallet -> Send navigation. Measured time between click, start of transition, end of transition
pr release build develop release build
1. 17(10) 18(12)
2. 15(9) 20(14)
3. 16(9) 15(10) allmost the same in this case
avg 16(9.3) 17.7(12)

Again, it is close to 100ms difference. Most likely it will be similar number for each transition, as we usually have 4-5 icons on each screen. There is no big difference in the whole transition time, but the animation is delayed in case if svg is used.

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

@errorists
I think there is no app's logo in that pngs archive #8195 (comment)

@errorists
Copy link
Contributor

errorists commented Jun 11, 2019

@rasom gotcha. Since these are not resolution independent anymore, can you tell me at which size (1x) we need the app logo? Is the largest one on the splash screen?

@errorists
Copy link
Contributor

thanks, exported one at 46x46 here Dropbox

@errorists
Copy link
Contributor

@rasom we should also use the 46 in all those instances since it's larger, downsizing is perfectly fine with PNGs.

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

@errorists ok then, thanks

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

@errorists it actually was 46 for "S" icon and 111 for the whole thing...

@errorists
Copy link
Contributor

@rasom 🤔 111 is a weird number to have but anyway this will be updated with new onboarding. Updated the resources in the dropbox link above, it's 111 now.

@rasom
Copy link
Contributor Author

rasom commented Jun 11, 2019

@Serhy Serhy self-assigned this Jun 12, 2019
@Serhy
Copy link
Contributor

Serhy commented Jun 12, 2019

Several issues after migration to PNG (some of them are iOS specific):

  1. Some icons became bigger than in develop (Group/Pubic chat icon on Home screen, 'lock' icon in browser bar):

Screenshot 2019-06-12 at 12 24 19

  1. Lost icons on
    a) Fleets settings screen
    b) Home -> Search chat -> Messages
    c) Group chat -> Group info -> Delete chat [iOS only]

Screenshot 2019-06-12 at 12 32 04

  1. Two lost icons on sticker selection pad:

Screenshot 2019-06-12 at 12 41 41

  1. The + char is not centred on a) Dapp permission on DApps screen and b) sticker selection area:

Screenshot 2019-06-12 at 12 52 51

  1. Lost upper-arrow icon on Send Message button [iOS only]

Screenshot 2019-06-12 at 13 04 54

  1. Lost icons on Log Level screen:

Screenshot 2019-06-12 at 13 22 28

  1. Lost icons on outgoing/pending/incoming transaction history and filter history screens [iOS only]

Screenshot 2019-06-12 at 13 18 40

@errorists
Copy link
Contributor

errorists commented Jun 12, 2019

@rasom hey, this has me wondering, do we need to supply the Android specific image formats so MDPI-HDPI-XHDPI-XXHDPI-XXXHDPI or will having only the iOS ones like @1x @2x @3x be enough? facebook docs seems to be convinced just having the iOS ones is enough. With regards to the sticker icons, I forgot to export them sorry, they are available here Dropbox

@rasom rasom requested a review from vkjr as a code owner June 12, 2019 19:05
@rasom
Copy link
Contributor Author

rasom commented Jun 13, 2019

@Serhy issues should be fixed now

@rasom
Copy link
Contributor Author

rasom commented Jun 13, 2019

@errorists

do we need to supply the Android specific image formats so MDPI-HDPI-XHDPI-XXHDPI-XXXHDPI or will having only the iOS ones like @1x @2x @3x be enough?

have no idea tbh

@Serhy
Copy link
Contributor

Serhy commented Jun 13, 2019

@rasom it's good, one last item though (sorry didn't notice on the previous build)
[iOS only] Lost icon on 'Add to contacts' of users profile who are not in contact list:
Screenshot 2019-06-13 at 18 05 55

@rasom
Copy link
Contributor Author

rasom commented Jun 17, 2019

@Serhy I just pushed fix

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 47
Failed tests: 0
Passed tests: 47

Passed tests (47)

Click to expand
1. test_block_user_from_public_chat (TestRail link is not found)
Device sessions

2. test_filters_from_daap (TestRail link is not found)
Device sessions

3. test_copy_and_paste_messages (TestRail link is not found)
Device sessions

4. test_send_transaction_from_daap (TestRail link is not found)
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat (TestRail link is not found)
Device sessions

6. test_deploy_contract_from_daap (TestRail link is not found)
Device sessions

7. test_open_transaction_on_etherscan (TestRail link is not found)
Device sessions

8. test_public_chat_messaging (TestRail link is not found)
Device sessions

9. test_long_press_to_delete_1_1_chat (TestRail link is not found)
Device sessions

10. test_password_in_logcat_sign_in (TestRail link is not found)
Device sessions

11. test_text_message_1_1_chat (TestRail link is not found)
Device sessions

12. test_add_to_contacts (TestRail link is not found)
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat (TestRail link is not found)
Device sessions

15. test_logcat_send_transaction_from_daap (TestRail link is not found)
Device sessions

16. test_send_message_in_group_chat (TestRail link is not found)
Device sessions

17. test_logcat_send_transaction_from_wallet (TestRail link is not found)
Device sessions

18. test_send_token_with_7_decimals (TestRail link is not found)
Device sessions

19. test_send_eth_from_wallet_to_address (TestRail link is not found)
Device sessions

20. test_manage_assets (TestRail link is not found)
Device sessions

21. test_logcat_send_transaction_in_1_1_chat (TestRail link is not found)
Device sessions

22. test_request_and_receive_eth_in_1_1_chat (TestRail link is not found)
Device sessions

23. test_long_press_to_delete_public_chat (TestRail link is not found)
Device sessions

24. test_send_emoji (TestRail link is not found)
Device sessions

25. test_search_chat_on_home (TestRail link is not found)
Device sessions

26. test_logcat_recovering_account (TestRail link is not found)
Device sessions

27. test_messaging_in_different_networks (TestRail link is not found)
Device sessions

28. test_send_tokens_in_1_1_chat (TestRail link is not found)
Device sessions

29. test_network_mismatch_for_send_request_commands (TestRail link is not found)
Device sessions

30. test_logcat_sign_message_from_daap (TestRail link is not found)
Device sessions

31. test_switch_users_and_add_new_account (TestRail link is not found)
Device sessions

32. test_send_stt_from_wallet (TestRail link is not found)
Device sessions

33. test_login_with_new_account (TestRail link is not found)
Device sessions

34. test_send_eth_from_wallet_to_contact (TestRail link is not found)
Device sessions

35. test_add_contact_from_public_chat (TestRail link is not found)
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp (TestRail link is not found)
Device sessions

37. test_password_in_logcat_creating_account (TestRail link is not found)
Device sessions

38. test_backup_recovery_phrase (TestRail link is not found)
Device sessions

39. test_offline_status (TestRail link is not found)
Device sessions

40. test_open_google_com_via_open_dapp (TestRail link is not found)
Device sessions

41. test_unread_messages_counter_public_chat (TestRail link is not found)
Device sessions

42. test_sign_message_from_daap (TestRail link is not found)
Device sessions

43. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions

44. test_share_contact_code_and_wallet_address (TestRail link is not found)
Device sessions

45. test_request_eth_in_wallet (TestRail link is not found)
Device sessions

46. test_refresh_button_browsing_app_webview (TestRail link is not found)
Device sessions

47. test_backup_recovery_phrase_warning_from_wallet (TestRail link is not found)
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Jun 18, 2019

@rasom, perfect! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants