Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check tribute if contact was added #8411

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Check tribute if contact was added #8411

merged 1 commit into from
Jun 19, 2019

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Jun 13, 2019 •
edited by StatusWrike
Loading

Fixes #8406

@vitvly vitvly requested a review from a team as a code owner June 13, 2019 12:42
@auto-assign auto-assign bot removed the request for review from a team June 13, 2019 12:43
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@vitvly vitvly requested review from flexsurfer, yenda, jeluard and a team June 13, 2019 12:43
@vitvly vitvly self-assigned this Jun 13, 2019
cammellos
cammellos suggested changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@cammellos cammellos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a test would have been helpful catching this, please add some covering the function.

@cammellos
Copy link
Contributor

@flexsurfer @jeluard please do not approve PRs if no tests, a fix should come with a test covering the case when it makes sense (in this case for example). thanks

@status-im-auto
Copy link
Member

status-im-auto commented Jun 13, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2dcf1f5 #1 2019-06-13 12:53:55 ~10 min linux 📦 App
✔️ 2dcf1f5 #1 2019-06-13 12:54:04 ~10 min android-e2e 📦 apk
✔️ 2dcf1f5 #1 2019-06-13 12:54:10 ~11 min ios 📦 ipa
✔️ 2dcf1f5 #1 2019-06-13 12:55:11 ~12 min android 📦 apk
✔️ 2dcf1f5 #1 2019-06-13 12:59:57 ~16 min windows 📦 exe
✔️ 2dcf1f5 #1 2019-06-13 13:03:27 ~20 min macos 📦 dmg
✔️ 99dbd76 #3 2019-06-18 16:04:59 ~11 min ios 📦 ipa
✔️ 99dbd76 #3 2019-06-18 16:05:19 ~12 min macos 📦 dmg
✔️ 99dbd76 #3 2019-06-18 16:10:08 ~17 min android 📦 apk
✔️ 99dbd76 #3 2019-06-18 16:10:19 ~17 min android-e2e 📦 apk
✔️ 99dbd76 #3 2019-06-18 16:11:34 ~18 min linux 📦 App
✔️ 99dbd76 #3 2019-06-18 16:12:35 ~19 min windows 📦 exe

@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
@vitvly vitvly force-pushed the fix/8406-no-input-field-when-adding-contact branch from 2dcf1f5 to d86fd29 Compare June 18, 2019 15:51
@vitvly
Copy link
Contributor Author

vitvly commented Jun 18, 2019

@cammellos added tests for check-tribute.

@vitvly vitvly force-pushed the fix/8406-no-input-field-when-adding-contact branch from d86fd29 to 99dbd76 Compare June 18, 2019 15:52
@statustestbot
Copy link

55% of end-end tests have passed

Total executed tests: 47
Failed tests: 21
Passed tests: 26

Failed tests (21)

Click to expand
1. test_block_user_from_public_chat

Device 1: Tap on SignInButton
Device 1: Tap on PlusButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

2. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

3. test_deploy_contract_from_daap

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

4. test_open_transaction_on_etherscan

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

5. test_sign_typed_message (TestRail link is not found)

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

6. test_logcat_send_transaction_from_daap

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

7. test_logcat_send_transaction_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

8. test_send_token_with_7_decimals

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

9. test_send_eth_from_wallet_to_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

10. test_manage_assets

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

11. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

12. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

13. test_send_tokens_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

14. test_network_mismatch_for_send_request_commands

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

15. test_send_stt_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

16. test_send_eth_from_wallet_to_contact

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

17. test_send_two_transactions_one_after_another_in_dapp

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

18. test_offline_status

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'home_button'

Device sessions

19. test_share_contact_code_and_wallet_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

20. test_request_eth_in_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

21. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

Passed tests (26)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_public_chat_messaging
Device sessions

5. test_long_press_to_delete_1_1_chat
Device sessions

6. test_password_in_logcat_sign_in
Device sessions

7. test_text_message_1_1_chat
Device sessions

8. test_add_to_contacts
Device sessions

9. test_unread_messages_counter_1_1_chat
Device sessions

10. test_send_message_in_group_chat
Device sessions

11. test_long_press_to_delete_public_chat
Device sessions

12. test_send_emoji
Device sessions

13. test_search_chat_on_home
Device sessions

14. test_logcat_recovering_account
Device sessions

15. test_messaging_in_different_networks
Device sessions

16. test_logcat_sign_message_from_daap
Device sessions

17. test_switch_users_and_add_new_account
Device sessions

18. test_login_with_new_account
Device sessions

19. test_add_contact_from_public_chat
Device sessions

20. test_password_in_logcat_creating_account
Device sessions

21. test_backup_recovery_phrase
Device sessions

22. test_open_google_com_via_open_dapp
Device sessions

23. test_unread_messages_counter_public_chat
Device sessions

24. test_sign_message_from_daap
Device sessions

25. test_user_can_remove_profile_picture
Device sessions

26. test_refresh_button_browsing_app_webview
Device sessions

@asemiankevich asemiankevich self-assigned this Jun 19, 2019
@vitvly
Copy link
Contributor Author

vitvly commented Jun 19, 2019

@asemiankevich if you're both on the same network (Ropsten), and your contact has tribute-to-talk on and didn't add you as a contact before, you should see a payment option and the chat input should be hidden.

@asemiankevich
Copy link
Contributor

@asemiankevich if you're both on the same network (Ropsten), and your contact has tribute-to-talk on and didn't add you as a contact before, you should see a payment option and the chat input should be hidden.

nevermid, i forgot about ropsten , sorry for false alarm

@asemiankevich
Copy link
Contributor

i've checked there:

  • adding a contact who does not have TTT enabled previously (chat input is enabled fine)
  • adding a contact who has TTT enabled (chat input is disabled, message shown for TTT payment)
  • pairing the devices
  • messaging 1x1, group chats, public chats - looks fine
  • looks there is known issue with TTT that i can't chat after payment done Can't get messages after paying TTT #8346, but i was able to - at least i can exchange some messages with desktop after i paid tribute on mobile

Looks good to me to be merged as is.

tests are failed to known reason, we are working on fixing this as soon as possible.

Check tribute if contact was added (but not otherwise)
b6163b8 
Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>
@vitvly vitvly force-pushed the fix/8406-no-input-field-when-adding-contact branch from 99dbd76 to b6163b8 Compare June 19, 2019 12:19
@vitvly vitvly merged commit b6163b8 into develop Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/8406-no-input-field-when-adding-contact branch June 19, 2019 12:19
@weekly-digest weekly-digest bot mentioned this pull request Jun 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@cammellos cammellos cammellos approved these changes

@jeluard jeluard jeluard approved these changes

@yenda yenda Awaiting requested review from yenda

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@churik churik Awaiting requested review from churik

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No input field in 1:1 chat is shown for some of the contacts
7 participants
@vitvly @cammellos @status-im-auto @statustestbot @asemiankevich @jeluard @flexsurfer