Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node_modules permissions before git clean #8413

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Jun 13, 2019

This is due to copying node_modules from nix store which is read-only.
Should fix Nightly build errors like this:

22:59:43  + make clean
22:59:43  git clean -dxf -f
22:59:44  warning: failed to remove node_modules/is-plain-obj/license: Permission denied
22:59:44  warning: failed to remove node_modules/is-plain-obj/index.js: Permission denied
22:59:44  warning: failed to remove node_modules/is-plain-obj/readme.md: Permission denied
22:59:44  warning: failed to remove node_modules/is-plain-obj/package.json: Permission denied
22:59:44  warning: failed to remove node_modules/plist/LICENSE: Permission denied
...

https://ci.status.im/job/status-react/job/nightly/1114/

@jakubgs jakubgs requested a review from a team as a code owner June 13, 2019 13:42
@jakubgs jakubgs self-assigned this Jun 13, 2019
@auto-assign auto-assign bot removed the request for review from a team June 13, 2019 13:42
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jun 13, 2019

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
401bb33 #1 2019-06-13 13:42:54 ~15 sec android-e2e 📄 log
401bb33 #1 2019-06-13 13:43:10 ~29 sec android 📄 log
401bb33 #1 2019-06-13 13:43:26 ~41 sec windows 📄 log
401bb33 #1 2019-06-13 13:43:27 ~44 sec linux 📄 log
401bb33 #1 2019-06-13 13:44:15 ~1 min ios 📄 log
401bb33 #1 2019-06-13 13:44:31 ~1 min macos 📄 log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 74b27aa #2 2019-06-13 13:59:25 ~12 min android-e2e 📦 apk
✔️ 74b27aa #2 2019-06-13 14:01:21 ~14 min ios 📦 ipa
✔️ 74b27aa #2 2019-06-13 14:02:03 ~14 min android 📦 apk
✔️ 74b27aa #2 2019-06-13 14:04:42 ~17 min linux 📦 App
✔️ 74b27aa #2 2019-06-13 14:06:12 ~18 min macos 📦 dmg
✔️ 74b27aa #2 2019-06-13 14:08:17 ~20 min windows 📦 exe
✔️ 1a4763c #3 2019-06-13 14:46:39 ~24 min android-e2e 📦 apk

this is due to copying node_modules from nix store which is read-only

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants