Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type of QueriesExpressions::newBaseQueryBuilder() #57

Closed
devantoine opened this issue Jul 10, 2024 · 3 comments
Closed

Wrong return type of QueriesExpressions::newBaseQueryBuilder() #57

devantoine opened this issue Jul 10, 2024 · 3 comments

Comments

@devantoine
Copy link

devantoine commented Jul 10, 2024

Hello,

I'm trying to have my IDE figuring out the added query builder's methods such as withExpression().

I've noticed that the return type of QueriesExpressions::newBaseQueryBuilder() is set to \Illuminate\Database\Query\Builder while it returns a Staudenmeir\LaravelCte\Query\Builder object.

There was a PR fixing that typing issue which then was reverted by this PR: https://github.com/staudenmeir/laravel-cte/pull/50/files

It won't fix the IDE code completion when using DB facades but at least it'll work when calling QueriesExpressions::newBaseQueryBuilder().

@staudenmeir
Copy link
Owner

Hi @devantoine,
Not sure why I reverted that, looks like a merge regression (the PR was based on a pretty old branch). I'll look into it.

@staudenmeir
Copy link
Owner

I released a new version that restores the return type.

@devantoine
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants