Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/entropy #3378

Closed
3 tasks done
stdlib-bot opened this issue Dec 8, 2024 · 0 comments · Fixed by #3379
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/entropy #3378

stdlib-bot opened this issue Dec 8, 2024 · 0 comments · Fixed by #3379
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Statistics Issue or pull request related to statistical functionality.

Comments

@stdlib-bot
Copy link
Contributor

Description

This RFC proposes adding a C implementation, including native Node.js addon, C benchmarks and C examples, for the @stdlib/stats/base/dists/arcsine/entropy package.

Prerequisites

  1. Review JavaScript implementation in lib/main.js and its required modules to identify all stdlib functions used.
  2. Verify C implementations exist for each required function.

Related Issues

#3355

Questions

No.

Other

Once the implementation is ready including C examples and benchmarks, we should be able to run the following make commands.

Build native add-on

NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/arcsine/entropy" make install-node-addons

Run C Examples

make examples-c-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/arcsine/entropy/examples/c/example.c"

Run C benchmarks

make benchmark-c-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/arcsine/entropy/benchmark/c/benchmark.c"

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter changed the title Add C implementation for @stdlib/stats/base/dists/arcsine/entropy [RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/entropy Dec 8, 2024
@Planeshifter Planeshifter added RFC Request for comments. Feature requests and proposed changes. Accepted RFC feature request which has been accepted. C Issue involves or relates to C. Statistics Issue or pull request related to statistical functionality. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. priority: Normal Normal priority concern or feature request. Feature Issue or pull request for adding a new feature. labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants