Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ feature ] Automating Mid-Install Temporary Directory Cleanup #301

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ feature ] Automating Mid-Install Temporary Directory Cleanup #301

wants to merge 5 commits into from

Conversation

Matthew-Mosior
Copy link
Contributor

@Matthew-Mosior Matthew-Mosior commented Aug 16, 2024 •
edited
Loading

This PR enables the removal of temporary directories that used to linger after a mid-install Ctrl+C.

To accomplish this, the idris2-async library is utilized to race two threads within the withTmpDir function:

  1. SigINT listener thread.
  2. Runner via finally thread.

This PR closes #288.

@Matthew-Mosior Matthew-Mosior marked this pull request as ready for review August 16, 2024 03:38
@Matthew-Mosior Matthew-Mosior changed the title [ feature] Automating Mid-Install Temporary Directory Cleanup [ feature ] Automating Mid-Install Temporary Directory Cleanup Aug 16, 2024
buzden
buzden reviewed Aug 16, 2024
View reviewed changes
src/Pack/Runner.idr Outdated Show resolved Hide resolved
@stefan-hoeck
Copy link
Owner

Thank you for taking the initiative here. I'll be happy to look into this once async becomes more stable. Right now, I'm still experimenting with different threadpool / runner implementations, and it is not yet clear how signal handling will work out.

On Linux, I'm planning to use epoll for timers, signal handlers, and asynchronous IO, but epoll only exists on Linux. For other Unix systems, there is kqueue but I have no experience with that.

tl,dr: It is too early to make async a dependency of a central tool such as pack. I'm currently spending a lot of my free time with async, but it is definitely a non-trivial library.

@Matthew-Mosior
Copy link
Contributor Author

Matthew-Mosior commented Aug 16, 2024 •
edited
Loading

@stefan-hoeck Not a problem, excited to help out in this direction!

Looking forward to seeing where async goes, it looks really solid already. Will be excited to hop back on this when the time is right (idris2-async is in a more stable place).

@buzden buzden added enhancement New feature or request blocked Solution is blocked by something external labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buzden buzden buzden left review comments

Assignees
No one assigned
Labels
blocked Solution is blocked by something external enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary directories not cleaned
3 participants
@Matthew-Mosior @stefan-hoeck @buzden