Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-note search #106

Closed
moshpirit opened this issue Mar 31, 2016 · 12 comments
Closed

in-note search #106

moshpirit opened this issue Mar 31, 2016 · 12 comments
Milestone

Comments

@moshpirit
Copy link

Would be adding a searcher inside the note (for long notes) a good idea?

Eg: I have a huge Markdown note for activism with links and descriptions.

This would be very useful but I also understand that might be not a very used feature for other people.

Note: commented on #19

@jancborchardt
Copy link
Member

Yeah, definitely. Simply a search icon in the top right next to the »more« icon just as in the main view would be good. :)

Then it’s search-as-you-type and the first result is directly focused. And the results placement could be highlighted in the scrollbar area (like Chrome does for example) to have a sense of placement.

@moshpirit
Copy link
Author

Or even inside the menu if you want a simple aesthetic, I don't mind.

I don't use Chrome (or anything from Google) but I think I get what you say; the top bar became something like this:

  • back button
  • searcher
  • last/next word as ↑↓ buttons

Right?

@jancborchardt
Copy link
Member

Yup, that as well.

@robinrosenstock
Copy link

What is the status of this feature request?

@stefan-niedermann
Copy link
Member

It has low priority for me but Pull Requests are welcome of course :-)

I provide 20,-€ for a working PR if someone is willing to take this.

@mario
Copy link
Contributor

mario commented May 14, 2018

@stefan-niedermann how many pancakes is that? :D

@stefan-niedermann
Copy link
Member

stefan-niedermann commented May 15, 2018

(i will hate myself for this, but:) how many can you eat at the conf? Let's say one per day plus some beer at the conf? 😆

@mario
Copy link
Contributor

mario commented May 15, 2018 via email

@stefan-niedermann
Copy link
Member

Your turn :)

@mario
Copy link
Contributor

mario commented May 15, 2018

Replace with wine and done! :D

@stefan-niedermann
Copy link
Member

Awaiting your PR ;-)

@stefan-niedermann
Copy link
Member

#400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants