-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse colors with alpha channel #674
Comments
We will just drop those for now in deck and apply the rgb values there, since both the frontend and database of deck currently only support plain colors without an alpha channel. However for the future it might make sense to already have this available in the app 😉 |
Yeah, we get some very strange inputs here, while Nextcloud returns a format like This tiny thing can break the whole sync (this usually pops up as an error, but when importing an account the very first time it can prevent the import at all). Therefore we have a util class and some unit tests to parse a color as good as possible. I now added a simple case to strip all alpha information for now, so this will definitely make no issues in the near future 😉 |
For reference: nextcloud/deck#1545 (comment)
It might be possible to receive color with a format
#rgba
and#rrggbbaa
. We need to make sure that ourColorUtil
is capable of parsing a correct color in this cases (+ extend the UnitTests).The text was updated successfully, but these errors were encountered: