Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automated release / tagging #48

Open
joshjohanning opened this issue Oct 25, 2022 · 4 comments
Open

Fix automated release / tagging #48

joshjohanning opened this issue Oct 25, 2022 · 4 comments
Assignees

Comments

@joshjohanning
Copy link
Contributor

See: #47 (comment)

For some odd reason the release pipeline was using an older commit as a baseline and this resulted in another 3.0.0 release ergo the pipeline failed with tag 'v3.0.0' already exists. I created the release manual for now, but the same happened earlier before as well see #43 (comment) @gr2m do you have any idea what is causing this?

Given this is happening since #39 it must be related to this change. Is there another way to address #23?

cc @stefanbuck @gr2m

@gr2m gr2m self-assigned this Oct 26, 2022
@evverx
Copy link

evverx commented Mar 31, 2024

Looking at systemd/systemd#25900 (comment) I wonder if the code was force-pushed and the history was overwritten at some point?

@gr2m
Copy link
Collaborator

gr2m commented May 31, 2024

Tags or commits currently cannot be used directly because they lack the dist/ folder, e.g. https://github.com/stefanbuck/github-issue-parser/tree/v3.2.0

I suggest we copy the setup of https://github.com/actions/create-github-app-token, where the dist/ folder is updated automatically as part of the release directly in the default branch. Repository rules now allow branch protections to be circumvented for actors, so we can register a single purpose GitHub App for this task, in order to keep branch protections in tact as they are

@gr2m
Copy link
Collaborator

gr2m commented May 31, 2024

See also #74

@jamacku
Copy link
Contributor

jamacku commented Dec 12, 2024

Also #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants