Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpha-2 and alpha-3 data violates ISO 3166-1:2020 #50

Closed
michael-o opened this issue Mar 15, 2021 · 4 comments
Closed

alpha-2 and alpha-3 data violates ISO 3166-1:2020 #50

michael-o opened this issue Mar 15, 2021 · 4 comments

Comments

@michael-o
Copy link

Chapter 5.1 says:

LATIN CAPITAL LETTER A through LATIN CAPITAL LETTER Z; Code elements alpha-2 and alpha-3 are formed with LETTERS,

All country codes in data is wrong because it does not use uppercase letters, but lowercase letters. Lowercase letters are used with ISO 639 for languages only.

Please correct the data.

@stefangabos
Copy link
Owner

wow, thanks for the update!
however, i will not fix this as the library is already widely used and i would break the internet :)

@michael-o
Copy link
Author

michael-o commented Mar 15, 2021

The leave this open and add a note to the README.

@stefangabos
Copy link
Owner

Sure, that I can do - can you please provide me the link to the docs where you found this information?

@michael-o
Copy link
Author

Well, access to ISO documents isn't unfortunately free: https://www.iso.org/obp/ui/#iso:std:iso:3166:-1:ed-4:v1:en. You have to buy the full document. I have full access to most standards document on the planet thanks to my employer, but here is a free-of-charge official list from the ISO. Select country codes and hit search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants