Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to check multiple routes in index #32

Open
stefanjudis opened this issue Jan 20, 2014 · 10 comments
Open

Make it possible to check multiple routes in index #32

stefanjudis opened this issue Jan 20, 2014 · 10 comments

Comments

@stefanjudis
Copy link
Owner

Follow up of #28 requested by @pgilad.

@stefanjudis
Copy link
Owner Author

@pgilad

Just thought about that. What about showing multiple routes in one graph? Seems to be better to me, then having tabs?

@davidlinse
Copy link

what about providing checkboxes to enable/disable the display multiple
routes in the graphs?

@stefanjudis
Copy link
Owner Author

Jep. Good idea! 👍

@stryju
Copy link
Collaborator

stryju commented Jan 27, 2014

any clear specs on that?

as far as i could understand:

  • create an option to test several routes/urls
  • display those routes on the same graphs with option to toggle them on/off

anything else?

i could give it a try, just need to know the specs ;-)

@stefanjudis
Copy link
Owner Author

Config should accept two types for url String and Array.

  options : {
        indexPath : './phantomas/',
        options   : {},
        url       : 'http://gruntjs.com/'
      }

&

  options : {
        indexPath : './phantomas/',
        options   : {},
        url       : ['http://gruntjs.com/', '...', '... ]
      }

@stryju
Copy link
Collaborator

stryju commented Jan 27, 2014

👍

will give it a try later on

this, however, will be a bit of a breaking change - filename-wise or data-structure-wise

  • filename would follow a pattern of [url-slug]-[timestamp].json
  • data-structure could contain the url prop

which one would be preferred?

@stefanjudis
Copy link
Owner Author

Would prefer to stick with [timestamp].json.

👍 for:

data-structure could contain the url prop

@stryju
Copy link
Collaborator

stryju commented Jan 27, 2014

ok, but now - how do we split the results across different urls?

on the top-level, like

{
  "example.com" : {
    "results" : { ... },
    "gzipRequests" : { ... },
    ...
  },
  "example.com/foo" : {
    "results" : { ... },
    "gzipRequests" : { ... },
    ...
  }
}

or on the individual prop level, like

{
  "results" : {
    "example.com" : { ... },
    "example.com/foo" : { ... },
    ...
  },
  "gzipRequests" : {
    "example.com" : { ... },
    "example.com/foo" : { ... },
    ...
  },
  ...
}

can we sum it up @ the top of this issue please? just so we have a clear specs in one place, not split across 100 comments :-)

@stefanjudis
Copy link
Owner Author

Both fine for me. ;)
But tend to like second version more.

@stefanjudis stefanjudis removed this from the 0.6.0 milestone Apr 2, 2014
@bootstraponline
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants