Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint.prototype.normalizeEntityName should be able to modify the entity name. #1283

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 5, 2014

No description provided.

@jgwhite
Copy link
Contributor

jgwhite commented Jul 5, 2014

Thought that line looked a little suspect. Good catch.

@@ -254,7 +256,9 @@ Blueprint.prototype.install = function(options) {
ui.write(chalk.yellow('You specified the dry-run flag, so no changes will be written.\n'));
}

if(options.entity) { this.normalizeEntityName( options.entity.name); }
if(options.entity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed whitespace.

@stefanpenner
Copy link
Contributor

what is an "entity" in this context?

@jgwhite
Copy link
Contributor

jgwhite commented Jul 5, 2014

@stefanpenner it's the thing you're generating.

ember generate <blueprint-name> <entity-name>

@stefanpenner
Copy link
Contributor

@jgwhite thanks :)

rwjblue added a commit that referenced this pull request Jul 6, 2014
…ange-name

Blueprint.prototype.normalizeEntityName should be able to modify the entity name.
@rwjblue rwjblue merged commit 342a354 into ember-cli:master Jul 6, 2014
@rwjblue rwjblue deleted the normalize-entityname-should-change-name branch July 6, 2014 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants