-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch config/environment.js and export app-name/config module. #1777
Conversation
var outputPath = path.join(destDir, relativePath); | ||
var configPath = path.join(this.options.project.root, srcDir, relativePath); | ||
var contents = fs.readFileSync(configPath, {encoding: 'utf8'}); | ||
contents = contents.replace('module.exports = function(environment) {', ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should just leave these, and then new Function
in a 'use strict' closure that implements them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
40b6117
to
bb27f84
Compare
bb27f84
to
1666d35
Compare
sg |
Watch config/environment.js and export app-name/config module.
This is a breaking change and I think this should be warned. |
Updated in 1c0c527 to indicate that it was a breaking change. |
@inDream when upgrading you should likely always run ember init and walk through the changes. Hopefully soon this project will be stable, nothing will change and we can work on better then :P |
@stefanpenner I've changed most files inside |
I'm aware that this change is a breaking change, but did you consider |
@kanongil Are you referring to using node's require? I was doing something like that too. For me, it wasn't a big deal as it was a minor convenience, but it would be nice if it still worked. Seems like some cool things could be brought out of using node in that file |
@jakecraige Exactly. Another issue I just noticed is the interaction with the |
@jakecraige, @kanongil - I fixed the ability to have your |
Also, when this transition is complete (still a few pieces to iron out), we will likely not use |
config/environment.js
changes.MyAppNameENV
).Addresses #1750.