-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple pre-processors per type. #1918
Allow multiple pre-processors per type. #1918
Conversation
Lgtm |
Allow multiple pre-processors per type.
What about preprocessors registered by addons as objects. They won't be part of |
Yes, they should be (ember-cli-esnext does this and works well alongside ember-cli-coffeescript for example). Please provide me an example where this is not true. Happy to track it down and fix if it is an oversight... |
Yeah I was just looking at your So I'm wondering what is the convention here. Do all preprocessors have to have the same name as the addon which has been installed via As an example say I have this addon: 'use strict';
module.exports = {
name: 'ember-cli-addon',
included: function(app) {
app.registry.add('js', {
name: 'ember-cli-preprocessor1',
ext: 'js',
toTree: function(tree) {}
});
app.registry.add('js', {
name: 'ember-cli-preprocessor2',
ext: 'js',
toTree: function(tree) {}
});
app.registry.add('template', {
name: 'ember-cli-preprocessor3',
ext: 'hbs',
toTree: function(tree) {}
});
}
}; |
Yes, that is a bug, @mbykovskyy - Can you open an issue with these last two comments in the subject? Shouldn't take long for me to fix, I just don't want to loose track... |
Yeah no problem. |
@rwjblue I made a quick change to my addon to make it work with the current change but I'm still not getting what I'm expecting. I'll comment under the appropriate line. |
Submitted #1987 to fix the preprocessing chaining issue mentioned. |
Registry.prototype.load
always returns an array of plugins available.