Close #2350 Fixes generated model relationship tests #2351
Conversation
| @@ -24,9 +24,9 @@ module.exports = { | |||
|
|
|||
| if (/has-many/.test(dasherizedType)) { | |||
| var camelizedNamePlural = inflection.pluralize(camelizedName); | |||
| attrs.push(camelizedNamePlural + ': ' + dsAttr(camelizedName, dasherizedType)); | |||
| attrs.push(camelizedNamePlural + ': ' + dsAttr(dasherizedName, dasherizedType)); | |||
this is a a good solution
My preference is only support 1 naming convention, dasherized. The motivation is to remove ambiguity and minimize confusion. |
| @@ -202,7 +202,11 @@ describe('Acceptance: ember generate', function() { | |||
| 'bars:has-many', | |||
| 'baz:belongs-to', | |||
| 'echo:hasMany', | |||
| 'bravo:belongs_to' | |||
| 'bravo:belongs_to', | |||
| 'barName:has-many', | |||
There was a problem hiding this comment.
should we also add foo-name:has-many as an example? (dasherized -> dasherized)
There was a problem hiding this comment.
Good call 👍 will add.
|
@stefanpenner great thank you :D. That AppVeyor issue appears to be the same that is on live. |
jonathanKingston
force-pushed
the
model-relationships
branch
from
46ff7f6 to
cbc7b48
Compare
|
@stefanpenner all changes pushed, thanks again. |
Ya we haven't had time to get the windows build to be green yet for the acceptance tests. Hopefully soon. |
Close #2350 Fixes generated model relationship tests
|
@stefanpenner 👍 thanks for merging. |
This is one way of resolving this issue. The other would be to make the resolver allow for both cases in uses:[] which would probably be the better solution.