-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmberApp specific helper for an upgradeable default brocfile. #396
Conversation
}); | ||
}); | ||
|
||
function injectENVJson(fn, env, tree, files) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add this to the prototype to make it easier to use from custom trees (and possible override)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah, I consider this still a hack. Once we have a proper solution for this, i will expose that.
Most if not all features should still be available
EmberApp specific helper for an upgradeable default brocfile.
@stefanpenner - Excellent work here. From all of our users everywhere: Thank you! |
@rjackson I hope this to be a foundation for us to iterate on. |
var qunitStyles = pickFiles('vendor', { | ||
srcDir: '/qunit/qunit', | ||
files: [ | ||
'qunit.css' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanpenner This file is not being picked. /assets/qunit.css
returns not found.
It has been a common pain point during upgrades, also a little intimidating for early users.
The goal for this is not to hide broccoli, as custom usage should not be discouraged.
Anything reasonable that now cannot be done should be considered a bugfix.
Most if not all features should still be available
Please note, as we improve our add-on story the
legacyFilesToAppend
+ignoredModules
+ignoredModules
should vanish.Likely what it would look like today (without the addon work)
Once we have a better add-on solution it will eventually look more like: