Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip the canary analysis #46

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Add option to skip the canary analysis #46

merged 6 commits into from
Feb 13, 2019

Conversation

stefanprodan
Copy link
Member

In emergency cases, you may want to skip the analysis phase and ship changes directly to production. At any time you can set the spec.skipAnalysis: true. When skip analysis is enabled, Flagger checks if the canary deployment is healthy and promotes it without analysing it. If an analysis is underway, Flagger cancels it and runs the promotion.

Fix: #45

When skip analysis is enabled, Flagger checks if the canary deployment is healthy and promotes it without analysing it. If an analysis is underway, Flagger cancels it and runs the promotion.
@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #46 into master will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   56.62%   56.63%   +0.01%     
==========================================
  Files           9        9              
  Lines        1305     1333      +28     
==========================================
+ Hits          739      755      +16     
- Misses        438      446       +8     
- Partials      128      132       +4
Impacted Files Coverage Δ
pkg/controller/scheduler.go 41.63% <57.14%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9c1ad...e565789. Read the comment docs.

@stefanprodan stefanprodan merged commit efd901a into master Feb 13, 2019
@stefanprodan stefanprodan deleted the skip-canary branch February 13, 2019 16:28
@stefanprodan stefanprodan mentioned this pull request Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants