This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

[Compliance]/send receives StatusCode 202 "pending" or 403 "denied" returns InternalServerError instead of Pending/Denied #109

Closed

acsanluis opened this issue Mar 23, 2018 · 1 comment

acsanluis commented Mar 23, 2018

https://github.com/stellar/bridge-server/blob/7a0a8f0444e7e83d67251aadb635ad3a64cb9f32/src/github.com/stellar/gateway/compliance/handlers/request_handler_send.go#L274

If other FI's compliance server returns 202 "pending" or 403 "denied", it will return InternalServerError as the if condition is != 200 only.

It should be:
if resp.StatusCode != 200 && resp.StatusCode != 202 && resp.StatusCode != 403 {
...
}

acsanluis mentioned this issue

return Pending/Denied if StatusCode is 202/403 #110

Merged

Contributor

bartekn commented Mar 26, 2018

Fixed in #110.

bartekn closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.