You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in #2022 , the memo value in a transaction can be an arbitrary binary blob even if the memo type is text. When horizon ingests transactions, it tries to store the memo field as a utf8 string even if the memo value is not valid utf8.
The Java SDK tries to recover the original byte representation of the memo by decoding the XDR. See lightsail-network/java-stellar-sdk#259 . However, we would like to avoiding XDR decoding in the SDKs when deserializing Horizon responses. The XDR definitions are subject to change so the SDKs should be relying on Horizon's API to avoid manually parsing XDR.
If we can include a memo_bytes field in the Horizon transaction resource, which is present alongside the memo field when memo_type is "text", then the Java SDK can use memo_bytes to recover the original memo value without having to parse envelope_xdr.
Once this feature is implemented, we should update the Java SDK to use the memo_bytes.
The text was updated successfully, but these errors were encountered:
As noted in #2022 , the memo value in a transaction can be an arbitrary binary blob even if the memo type is text. When horizon ingests transactions, it tries to store the memo field as a utf8 string even if the memo value is not valid utf8.
The Java SDK tries to recover the original byte representation of the memo by decoding the XDR. See lightsail-network/java-stellar-sdk#259 . However, we would like to avoiding XDR decoding in the SDKs when deserializing Horizon responses. The XDR definitions are subject to change so the SDKs should be relying on Horizon's API to avoid manually parsing XDR.
If we can include a
memo_bytes
field in the Horizon transaction resource, which is present alongside thememo
field whenmemo_type
is "text", then the Java SDK can usememo_bytes
to recover the original memo value without having to parseenvelope_xdr
.Once this feature is implemented, we should update the Java SDK to use the
memo_bytes
.The text was updated successfully, but these errors were encountered: