Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Horizon Docker image to support P19 #4377

Closed
jcx120 opened this issue May 10, 2022 · 5 comments
Closed

Update Horizon Docker image to support P19 #4377

jcx120 opened this issue May 10, 2022 · 5 comments

Comments

@jcx120
Copy link

jcx120 commented May 10, 2022

Update Captive Core in Horizon Docker image to support P19 version.

@2opremio
Copy link
Contributor

2opremio commented May 11, 2022

To solve the docker build caching problems we have, I think we should just add a build parameter with core's version. This will make docker cache things correctly.

Also, the horizon docker image tag should probably reflect the core version included (otherwise we may end up releasing mutable tags, i.e. different images with the same tag but different core versions).

@leighmcculloch
Copy link
Member

@2opremio There is conversation about this here: #4379 (comment)

@2opremio
Copy link
Contributor

@leighmcculloch thanks, I reposted it there.

@jcx120
Copy link
Author

jcx120 commented May 11, 2022

Closing this issue as its being addressed in #4379 (for removing cache)
Current Docker image also updated to unblock users.

@bartekn
Copy link
Contributor

bartekn commented May 12, 2022

GH didn't autoclose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants