Rollback SEP23 (Muxed Account strkeys) support #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
May 27, 2020
2opremio
reviewed
May 27, 2020
|
|
||
| char[] encoded = encodeCheck(VersionByte.MUXED_ACCOUNT, byteStream.toByteArray()); | ||
| return String.valueOf(encoded); | ||
| return encodeStellarAccountId(account.getMed25519().getEd25519().getUint256()); |
There was a problem hiding this comment.
Instead of modifying encodeStellarMuxedAccount to internally transform to an AccountId I would add a method to explicitly transform Muxed Accounts into account IDs. This is more explicit and there is no magic involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #277 (comment)